Re: [PR] Verify SSH host keys by default in SSH and SFTP hooks [airflow]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on PR #73419:
URL: https://github.com/apache/airflow/pull/73419#issuecomment-5985322921

   Thanks for digging into these. The first one is already fixed on main by #73593 — `_parse_extras` now compares against the expanded default, so an explicit constructor `known_hosts` wins over the connection extra, consistent with `SSHHookAsync`.
   
   The second is real and still there: the concurrent workers are built from `ssh_conn_id` alone (plus `no_host_key_check` after this PR), so any constructor overrides — `remote_host`, port, username, credentials, key file, proxy — are lost, and a directory listed through an explicit `remote_host` is downloaded from the connection's host. That's out of scope for this PR, so I've opened #74208 to track it.
   
   ---
   Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org