You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by Aravindan Vijayan <av...@hortonworks.com> on 2015/12/09 00:14:17 UTC

Review Request 41109: AMBARI-14278 : On a cluster with both AMS and Storm, stack advisor throws error in validateStormConfigurations after upgrade if the metrics.reporter.register property is not present

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41109/
-----------------------------------------------------------

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-14278
    https://issues.apache.org/jira/browse/AMBARI-14278


Repository: ambari


Description
-------

The Storm Metrics reporter property (metrics.reporter.register) is a known config item that needs to be added manually when upgraded from Ambari versions before 2.0.0 to any version with AMS. If that is not done, there is a stack advisor exception that is caused.

FIX
Added a check for the presence of the property. If the property is present, we add it to validation items. Else, we dont add to validation item


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py f3e6f8b 

Diff: https://reviews.apache.org/r/41109/diff/


Testing
-------

ambari-server python unit tests pass.

Manually tested.


Thanks,

Aravindan Vijayan

Re: Review Request 41109: AMBARI-14278 : On a cluster with both AMS and Storm, stack advisor throws error in validateStormConfigurations after upgrade if the metrics.reporter.register property is not present

Posted by Dmytro Sen <ds...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41109/#review109806
-----------------------------------------------------------

Ship it!


Ship It!

- Dmytro Sen


On Дек. 10, 2015, 6 п.п., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41109/
> -----------------------------------------------------------
> 
> (Updated Дек. 10, 2015, 6 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14278
>     https://issues.apache.org/jira/browse/AMBARI-14278
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The Storm Metrics reporter property (metrics.reporter.register) is a known config item that needs to be added manually when upgraded from Ambari versions before 2.0.0 to any version with AMS. If that is not done, there is a stack advisor exception that is caused.
> 
> FIX
> Added a check for the presence of the property. If the property is present, we add it to validation items. Else, we dont add to validation item
> 
> Steps to work around the issue
> 1. Add the following property to storm-site.xml from Ambari Web
> metrics.reporter.register = org.apache.hadoop.metrics2.sink.storm.StormTimelineMetricsReporter
> 2. Restart Storm service.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java f80f7b9 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py 60eb286 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 946deed 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java d83f0a8 
> 
> Diff: https://reviews.apache.org/r/41109/diff/
> 
> 
> Testing
> -------
> 
> ambari-server python unit tests pass.
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 41109: AMBARI-14278 : On a cluster with both AMS and Storm, stack advisor throws error in validateStormConfigurations after upgrade if the metrics.reporter.register property is not present

Posted by Aravindan Vijayan <av...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41109/
-----------------------------------------------------------

(Updated Dec. 10, 2015, 6 p.m.)

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.

Changes
-------

Manual upgrade (2.1.2 to 2.2.0) testing done.

Added a change to service check such that start_time and end_time values in the POST request are updated for every POST request.

Bugs: AMBARI-14278
https://issues.apache.org/jira/browse/AMBARI-14278

Repository: ambari

Description
-------

The Storm Metrics reporter property (metrics.reporter.register) is a known config item that needs to be added manually when upgraded from Ambari versions before 2.0.0 to any version with AMS. If that is not done, there is a stack advisor exception that is caused.

FIX
Added a check for the presence of the property. If the property is present, we add it to validation items. Else, we dont add to validation item

Steps to work around the issue
1. Add the following property to storm-site.xml from Ambari Web
metrics.reporter.register = org.apache.hadoop.metrics2.sink.storm.StormTimelineMetricsReporter
2. Restart Storm service.

Diffs (updated)
-----

ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java f80f7b9
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py 60eb286
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 946deed
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java d83f0a8

Diff: https://reviews.apache.org/r/41109/diff/

Testing
-------

ambari-server python unit tests pass.

Manually tested.

Thanks,

Aravindan Vijayan

Re: Review Request 41109: AMBARI-14278 : On a cluster with both AMS and Storm, stack advisor throws error in validateStormConfigurations after upgrade if the metrics.reporter.register property is not present

Posted by Sid Wagle <sw...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41109/#review109592
-----------------------------------------------------------

Ship it!


Need a green light on manual test results.

- Sid Wagle


On Dec. 9, 2015, 7:41 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41109/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 7:41 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14278
>     https://issues.apache.org/jira/browse/AMBARI-14278
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The Storm Metrics reporter property (metrics.reporter.register) is a known config item that needs to be added manually when upgraded from Ambari versions before 2.0.0 to any version with AMS. If that is not done, there is a stack advisor exception that is caused.
> 
> FIX
> Added a check for the presence of the property. If the property is present, we add it to validation items. Else, we dont add to validation item
> 
> Steps to work around the issue
> 1. Add the following property to storm-site.xml from Ambari Web
> metrics.reporter.register = org.apache.hadoop.metrics2.sink.storm.StormTimelineMetricsReporter
> 2. Restart Storm service.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java f80f7b9 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 946deed 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java d83f0a8 
> 
> Diff: https://reviews.apache.org/r/41109/diff/
> 
> 
> Testing
> -------
> 
> ambari-server python unit tests pass.
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 41109: AMBARI-14278 : On a cluster with both AMS and Storm, stack advisor throws error in validateStormConfigurations after upgrade if the metrics.reporter.register property is not present

Posted by Aravindan Vijayan <av...@hortonworks.com>.

(Updated Dec. 9, 2015, 7:41 p.m.)

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.

Changes
-------

Added the metrics.reporter.register to UpgradeCatalog220. Changed the name of the FIFO compaction enabled property in UpgradeCatalog220 to the correct one.

Bugs: AMBARI-14278
https://issues.apache.org/jira/browse/AMBARI-14278

Repository: ambari

Description
-------

FIX
Added a check for the presence of the property. If the property is present, we add it to validation items. Else, we dont add to validation item

Diffs (updated)
-----

ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java f80f7b9
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 946deed
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java d83f0a8

Diff: https://reviews.apache.org/r/41109/diff/

Testing
-------

ambari-server python unit tests pass.

Manually tested.

Thanks,

Aravindan Vijayan

Re: Review Request 41109: AMBARI-14278 : On a cluster with both AMS and Storm, stack advisor throws error in validateStormConfigurations after upgrade if the metrics.reporter.register property is not present

Posted by Aravindan Vijayan <av...@hortonworks.com>.


> On Dec. 9, 2015, 1:26 a.m., Sid Wagle wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py, line 911
> > <https://reviews.apache.org/r/41109/diff/1/?file=1156612#file1156612line911>
> >
> >     Validation looks good, but do we add this property correctly if AMS is present and Storm service exists?

Yes. It is part of recommendStormConfigurations.


- Aravindan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41109/#review109438
-----------------------------------------------------------


On Dec. 9, 2015, 12:02 a.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41109/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 12:02 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14278
>     https://issues.apache.org/jira/browse/AMBARI-14278
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The Storm Metrics reporter property (metrics.reporter.register) is a known config item that needs to be added manually when upgraded from Ambari versions before 2.0.0 to any version with AMS. If that is not done, there is a stack advisor exception that is caused.
> 
> FIX
> Added a check for the presence of the property. If the property is present, we add it to validation items. Else, we dont add to validation item
> 
> Steps to work around the issue
> 1. Add the following property to storm-site.xml from Ambari Web
> metrics.reporter.register = org.apache.hadoop.metrics2.sink.storm.StormTimelineMetricsReporter
> 2. Restart Storm service.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py f3e6f8b 
> 
> Diff: https://reviews.apache.org/r/41109/diff/
> 
> 
> Testing
> -------
> 
> ambari-server python unit tests pass.
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 41109: AMBARI-14278 : On a cluster with both AMS and Storm, stack advisor throws error in validateStormConfigurations after upgrade if the metrics.reporter.register property is not present

Posted by Sid Wagle <sw...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41109/#review109438
-----------------------------------------------------------



ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py (line 911)
<https://reviews.apache.org/r/41109/#comment168960>

    Validation looks good, but do we add this property correctly if AMS is present and Storm service exists?


- Sid Wagle


On Dec. 9, 2015, 12:02 a.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41109/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 12:02 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14278
>     https://issues.apache.org/jira/browse/AMBARI-14278
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The Storm Metrics reporter property (metrics.reporter.register) is a known config item that needs to be added manually when upgraded from Ambari versions before 2.0.0 to any version with AMS. If that is not done, there is a stack advisor exception that is caused.
> 
> FIX
> Added a check for the presence of the property. If the property is present, we add it to validation items. Else, we dont add to validation item
> 
> Steps to work around the issue
> 1. Add the following property to storm-site.xml from Ambari Web
> metrics.reporter.register = org.apache.hadoop.metrics2.sink.storm.StormTimelineMetricsReporter
> 2. Restart Storm service.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py f3e6f8b 
> 
> Diff: https://reviews.apache.org/r/41109/diff/
> 
> 
> Testing
> -------
> 
> ambari-server python unit tests pass.
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 41109: AMBARI-14278 : On a cluster with both AMS and Storm, stack advisor throws error in validateStormConfigurations after upgrade if the metrics.reporter.register property is not present

Posted by Sid Wagle <sw...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41109/#review109460
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On Dec. 9, 2015, 12:02 a.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41109/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 12:02 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14278
>     https://issues.apache.org/jira/browse/AMBARI-14278
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The Storm Metrics reporter property (metrics.reporter.register) is a known config item that needs to be added manually when upgraded from Ambari versions before 2.0.0 to any version with AMS. If that is not done, there is a stack advisor exception that is caused.
> 
> FIX
> Added a check for the presence of the property. If the property is present, we add it to validation items. Else, we dont add to validation item
> 
> Steps to work around the issue
> 1. Add the following property to storm-site.xml from Ambari Web
> metrics.reporter.register = org.apache.hadoop.metrics2.sink.storm.StormTimelineMetricsReporter
> 2. Restart Storm service.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py f3e6f8b 
> 
> Diff: https://reviews.apache.org/r/41109/diff/
> 
> 
> Testing
> -------
> 
> ambari-server python unit tests pass.
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 41109: AMBARI-14278 : On a cluster with both AMS and Storm, stack advisor throws error in validateStormConfigurations after upgrade if the metrics.reporter.register property is not present

Posted by Dmytro Sen <ds...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41109/#review109490
-----------------------------------------------------------

Ship it!


Ship It!

- Dmytro Sen


On Дек. 9, 2015, 12:02 д.п., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41109/
> -----------------------------------------------------------
> 
> (Updated Дек. 9, 2015, 12:02 д.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14278
>     https://issues.apache.org/jira/browse/AMBARI-14278
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The Storm Metrics reporter property (metrics.reporter.register) is a known config item that needs to be added manually when upgraded from Ambari versions before 2.0.0 to any version with AMS. If that is not done, there is a stack advisor exception that is caused.
> 
> FIX
> Added a check for the presence of the property. If the property is present, we add it to validation items. Else, we dont add to validation item
> 
> Steps to work around the issue
> 1. Add the following property to storm-site.xml from Ambari Web
> metrics.reporter.register = org.apache.hadoop.metrics2.sink.storm.StormTimelineMetricsReporter
> 2. Restart Storm service.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py f3e6f8b 
> 
> Diff: https://reviews.apache.org/r/41109/diff/
> 
> 
> Testing
> -------
> 
> ambari-server python unit tests pass.
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 41109: AMBARI-14278 : On a cluster with both AMS and Storm, stack advisor throws error in validateStormConfigurations after upgrade if the metrics.reporter.register property is not present

Posted by Aravindan Vijayan <av...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41109/
-----------------------------------------------------------

(Updated Dec. 9, 2015, 12:02 a.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-14278
    https://issues.apache.org/jira/browse/AMBARI-14278


Repository: ambari


Description (updated)
-------

The Storm Metrics reporter property (metrics.reporter.register) is a known config item that needs to be added manually when upgraded from Ambari versions before 2.0.0 to any version with AMS. If that is not done, there is a stack advisor exception that is caused.

FIX
Added a check for the presence of the property. If the property is present, we add it to validation items. Else, we dont add to validation item

Steps to work around the issue
1. Add the following property to storm-site.xml from Ambari Web
metrics.reporter.register = org.apache.hadoop.metrics2.sink.storm.StormTimelineMetricsReporter
2. Restart Storm service.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py f3e6f8b 

Diff: https://reviews.apache.org/r/41109/diff/


Testing
-------

ambari-server python unit tests pass.

Manually tested.


Thanks,

Aravindan Vijayan