You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/12 16:25:01 UTC

[GitHub] [cloudstack] Pearl1594 opened a new pull request #3963: Handle port forward rule check for vpc and non vpc Isolated networks

Pearl1594 opened a new pull request #3963: Handle port forward rule check for vpc and non vpc Isolated networks
URL: https://github.com/apache/cloudstack/pull/3963
 
 
   ## Description
   Port forwarding rules not checked properly on Isolated networks (non-VPC)
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   
   ## How Has This Been Tested?
   Created Isolated network and added port forward rules for the Instance created in that network
   Create an Instance in a tier of a VPC network and  ran the health check from UI and cmk with performfreshchecks as true
   All tests passed for both the routers
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] andrijapanicsb commented on issue #3963: Handle port forward rule check for vpc and non vpc Isolated networks

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3963: Handle port forward rule check for vpc and non vpc Isolated networks
URL: https://github.com/apache/cloudstack/pull/3963#issuecomment-598282692
 
 
   @blueorangutan package

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3963: Handle port forward rule check for vpc and non vpc Isolated networks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3963: Handle port forward rule check for vpc and non vpc Isolated networks
URL: https://github.com/apache/cloudstack/pull/3963#issuecomment-598638667
 
 
   <b>Trillian test result (tid-1239)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 56268 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3963-t1239-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Smoke tests completed. 83 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3963: Handle port forward rule check for vpc and non vpc Isolated networks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3963: Handle port forward rule check for vpc and non vpc Isolated networks
URL: https://github.com/apache/cloudstack/pull/3963#issuecomment-598283413
 
 
   @andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3963: Handle port forward rule check for vpc and non vpc Isolated networks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3963: Handle port forward rule check for vpc and non vpc Isolated networks
URL: https://github.com/apache/cloudstack/pull/3963#issuecomment-598295811
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1045

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland merged pull request #3963: Handle port forward rule check for vpc and non vpc Isolated networks

Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #3963: Handle port forward rule check for vpc and non vpc Isolated networks
URL: https://github.com/apache/cloudstack/pull/3963
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] weizhouapache commented on issue #3963: Handle port forward rule check for vpc and non vpc Isolated networks

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3963: Handle port forward rule check for vpc and non vpc Isolated networks
URL: https://github.com/apache/cloudstack/pull/3963#issuecomment-598431117
 
 
   tested. it works fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] andrijapanicsb commented on issue #3963: Handle port forward rule check for vpc and non vpc Isolated networks

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3963: Handle port forward rule check for vpc and non vpc Isolated networks
URL: https://github.com/apache/cloudstack/pull/3963#issuecomment-598330926
 
 
   @blueorangutan test

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3963: Handle port forward rule check for vpc and non vpc Isolated networks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3963: Handle port forward rule check for vpc and non vpc Isolated networks
URL: https://github.com/apache/cloudstack/pull/3963#issuecomment-598331177
 
 
   @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] andrijapanicsb commented on issue #3963: Handle port forward rule check for vpc and non vpc Isolated networks

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3963: Handle port forward rule check for vpc and non vpc Isolated networks
URL: https://github.com/apache/cloudstack/pull/3963#issuecomment-598478494
 
 
   thx @weizhouapache, that's one thing less for me to test :))
   
   Thx

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services