You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by "Keith Turner (JIRA)" <ji...@apache.org> on 2012/08/23 18:24:42 UTC

[jira] [Created] (ACCUMULO-740) Infinite loop in RFile code

Keith Turner created ACCUMULO-740:
-------------------------------------

             Summary: Infinite loop in RFile code
                 Key: ACCUMULO-740
                 URL: https://issues.apache.org/jira/browse/ACCUMULO-740
             Project: Accumulo
          Issue Type: Bug
            Reporter: Keith Turner
             Fix For: 1.5.0


Saw an infinite loop in RFile code when new on demand indexing was turned on and table contained zero length values.  I think this is only an issue in trunk, but need to analyze 1.4 code to make sure it does not happen. 

The problematic code is 

{noformat}
org.apache.accumulo.core.file.rfile.RelativeKey.read(DataInput in, MByteSequence mbseq, int len){...}
{noformat}

When the input mbseq is backed by a zero length array, an infinite loop will occur.  Also noticed that the code could overflow the integer and cause an inifinite loop (a key or value > 2^30 would be needed to trigger this).  I suspect 1.4 will never generate an input that will cause the infinite loop, but I am not 100% sure about this.  



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ACCUMULO-740) Infinite loop in RFile code

Posted by "Keith Turner (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ACCUMULO-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440419#comment-13440419 ] 

Keith Turner commented on ACCUMULO-740:
---------------------------------------

Changes made for ACCUMULO-473 exposed this bug
                
> Infinite loop in RFile code
> ---------------------------
>
>                 Key: ACCUMULO-740
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-740
>             Project: Accumulo
>          Issue Type: Bug
>            Reporter: Keith Turner
>             Fix For: 1.5.0
>
>
> Saw an infinite loop in RFile code when new on demand indexing was turned on and table contained zero length values.  I think this is only an issue in trunk, but need to analyze 1.4 code to make sure it does not happen. 
> The problematic code is 
> {noformat}
> org.apache.accumulo.core.file.rfile.RelativeKey.read(DataInput in, MByteSequence mbseq, int len){...}
> {noformat}
> When the input mbseq is backed by a zero length array, an infinite loop will occur.  Also noticed that the code could overflow the integer and cause an inifinite loop (a key or value > 2^30 would be needed to trigger this).  I suspect 1.4 will never generate an input that will cause the infinite loop, but I am not 100% sure about this.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (ACCUMULO-740) Infinite loop in RFile code

Posted by "Keith Turner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ACCUMULO-740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith Turner resolved ACCUMULO-740.
-----------------------------------

    Resolution: Fixed
      Assignee: Keith Turner

I looked at 1.4, this bug will not occur there.  I do not think it will ever call the function w/ a zero length array.  Code changes for 1.5 introduced the possibility of calling the function with a zero length array.

I do not think this bug fix needs to be back ported to 1.4
                
> Infinite loop in RFile code
> ---------------------------
>
>                 Key: ACCUMULO-740
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-740
>             Project: Accumulo
>          Issue Type: Bug
>            Reporter: Keith Turner
>            Assignee: Keith Turner
>             Fix For: 1.5.0
>
>
> Saw an infinite loop in RFile code when new on demand indexing was turned on and table contained zero length values.  I think this is only an issue in trunk, but need to analyze 1.4 code to make sure it does not happen. 
> The problematic code is 
> {noformat}
> org.apache.accumulo.core.file.rfile.RelativeKey.read(DataInput in, MByteSequence mbseq, int len){...}
> {noformat}
> When the input mbseq is backed by a zero length array, an infinite loop will occur.  Also noticed that the code could overflow the integer and cause an inifinite loop (a key or value > 2^30 would be needed to trigger this).  I suspect 1.4 will never generate an input that will cause the infinite loop, but I am not 100% sure about this.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira