You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/03/09 08:15:52 UTC
[PR] GH-40432: [C++] Add missing Threads::Threads dependency to arrow_static [arrow]
kou opened a new pull request, #40433:
URL: https://github.com/apache/arrow/pull/40433
### Rationale for this change
`libarrow.a` uses `std::mutex` and so on. So we need to link to `Threads::Threads`. But #39824 dropped it accidentally.
### What changes are included in this PR?
Add unexpectedly dropped `Threads::Threads` dependency to `arrow_static` again.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40432: [C++] Add missing Threads::Threads dependency to arrow_static [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40433:
URL: https://github.com/apache/arrow/pull/40433#issuecomment-1986791173
Revision: 68fbcb41758200419e7372855d2ca6557953cf2a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-986a8c0b5e](https://github.com/ursacomputing/crossbow/branches/all?query=actions-986a8c0b5e)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/8213279895/job/22464488893)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/8213279540/job/22464488311)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/8213279384/job/22464487864)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8213279648/job/22464488511)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/8213279811/job/22464488887)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8213279692/job/22464488518)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/22464489777)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8213279566/job/22464488344)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8213279538/job/22464488318)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/8213280031/job/22464489240)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8213279500/job/22464488158)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8213279997/job/22464489243)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/8213279817/job/22464488889)|
|test-ubuntu-20.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/8213279719/job/22464488653)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/8213279778/job/22464488717)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8213279814/job/22464488773)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/8213279353/job/22464487865)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/8213279709/job/22464488656)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8213279531/job/22464488310)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/8213279377/job/22464487856)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40432: [C++] Add missing Threads::Threads dependency to arrow_static [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #40433:
URL: https://github.com/apache/arrow/pull/40433#issuecomment-1986971400
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40432: [C++] Add missing Threads::Threads dependency to arrow_static [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40433:
URL: https://github.com/apache/arrow/pull/40433#issuecomment-1986790657
:warning: GitHub issue #40432 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40432: [C++] Add missing Threads::Threads dependency to arrow_static [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #40433:
URL: https://github.com/apache/arrow/pull/40433#issuecomment-1986790602
@github-actions crossbow submit example-cpp-* -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40432: [C++] Add missing Threads::Threads dependency to arrow_static [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #40433:
URL: https://github.com/apache/arrow/pull/40433#issuecomment-1987033424
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 6a7a6ee308b69c12f46f874cb3d52892e172d7b7.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/22475633857) has more details. It also includes information about 15 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40432: [C++] Add missing Threads::Threads dependency to arrow_static [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #40433:
URL: https://github.com/apache/arrow/pull/40433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org