[GitHub] [iceberg] Fokko commented on a diff in pull request #8524: Python: Fix pyarrow hdfs support

["Fokko (via GitHub)" <gi...@apache.org>]

Fokko commented on code in PR #8524:
URL: https://github.com/apache/iceberg/pull/8524#discussion_r1320656534


##########
python/tests/io/test_pyarrow.py:
##########
@@ -1527,3 +1527,19 @@ def test_writing_avro_file_gcs(generated_manifest_entry_file: str, pyarrow_filei
             assert b1 == b2  # Check that bytes of read from local avro file match bytes written to s3
 
     pyarrow_fileio_gcs.delete(f"gs://warehouse/{filename}")
+
+
+def test_parse_hdfs_location() -> None:

Review Comment:
   Ah, I see. The other arrow file systems require the scheme to be removed, but for hdfs you can access both local files and on hdfs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org