You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/20 00:27:10 UTC
[GitHub] [airflow] xinbinhuang commented on a change in pull request #7214:
[AIRFLOW-6597] Surface ODBC conn_type in Webserver UI Connection Form
xinbinhuang commented on a change in pull request #7214: [AIRFLOW-6597] Surface ODBC conn_type in Webserver UI Connection Form
URL: https://github.com/apache/airflow/pull/7214#discussion_r368336699
##########
File path: airflow/models/connection.py
##########
@@ -66,43 +66,44 @@ class Connection(Base, LoggingMixin):
_extra = Column('extra', String(5000))
_types = [
- ('docker', 'Docker Registry',),
+ ('docker', 'Docker Registry'),
('fs', 'File (path)'),
- ('ftp', 'FTP',),
+ ('ftp', 'FTP'),
('google_cloud_platform', 'Google Cloud Platform'),
- ('hdfs', 'HDFS',),
- ('http', 'HTTP',),
- ('pig_cli', 'Pig Client Wrapper',),
- ('hive_cli', 'Hive Client Wrapper',),
- ('hive_metastore', 'Hive Metastore Thrift',),
- ('hiveserver2', 'Hive Server 2 Thrift',),
- ('jdbc', 'Jdbc Connection',),
+ ('hdfs', 'HDFS'),
+ ('http', 'HTTP'),
+ ('pig_cli', 'Pig Client Wrapper'),
+ ('hive_cli', 'Hive Client Wrapper'),
+ ('hive_metastore', 'Hive Metastore Thrift'),
+ ('hiveserver2', 'Hive Server 2 Thrift'),
+ ('jdbc', 'JDBC Connection'),
+ ('odbc', 'ODBC Connection'),
Review comment:
This is the only addition. `ODBC Connection`. The rest modifications are just to remove trailing `,` in the tuples to make it consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services