You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/07/24 21:45:03 UTC

[GitHub] Ishitori commented on a change in pull request #11765: Fix file name creation for Windows

Ishitori commented on a change in pull request #11765: Fix file name creation for Windows
URL: https://github.com/apache/incubator-mxnet/pull/11765#discussion_r204921714
 
 

 ##########
 File path: docs/tutorials/python/predict_image.md
 ##########
 @@ -57,8 +57,8 @@ from collections import namedtuple
 Batch = namedtuple('Batch', ['data'])
 
 def get_image(url, show=False):
-    # download and show the image
-    fname = mx.test_utils.download(url)
+    # download and show the image. Remove query string from the file name.
+    fname = mx.test_utils.download(url, fname=url.split('/')[-1].split('?')[0])
 
 Review comment:
   Yeah, I don't think it will happen here, because the fix is done only for this particular tutorial - all urls are known in advance.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services