You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@trafficserver.apache.org by Randy DuCharame <ra...@ad5gb.com> on 2020/07/23 09:33:52 UTC
Is "proxy.config.net.max_requests_in" invalid?
Greetings,
I'm running a build from the latest sources and am now seeing:
"WARNING: Unrecognized configuration value
'proxy.config.net.max_requests_in''
showing up in diags.log. I'm not coming up with anything in searching
but I've not yet started digging through code. I was hoping someone
with more experience with ATS would know. :-) I'm a relative noob to
the proxy. I've probably done something stupid but not sure what.
Many thanks in advance!
--
Randall DuCharme (Radio AD5GB)
Powered entirely by Open Source software.
Re: Is "proxy.config.net.max_requests_in" invalid?
Posted by Randy DuCharame <ra...@ad5gb.com>.
Sure. I'll have to figure out how to do it for this project, but it's
on the way.
Thank you!
On 7/23/2020 7:33 AM, Sudheer Vinukonda wrote:
> Ah, this looks like a bug in a change that I made recently. Thanks for
> reporting and fixing it. Could you pls create a PR?
>
>> On Jul 23, 2020, at 5:21 AM, Randy DuCharame <ra...@ad5gb.com> wrote:
>>
>>
>>
>> Well, Damian's reply got me to scratching around in the code. Seems
>> that the changes in the diff below fixes the warning. I guess I'll
>> test some things to see if it does the expected thing and submit a
>> patch. Again, I'm a NOOB when it comes to TS.
>>
>>
>> diff --git a/mgmt/RecordsConfig.cc b/mgmt/RecordsConfig.cc
>> index 30515e201..6059226bc 100644
>> --- a/mgmt/RecordsConfig.cc
>> +++ b/mgmt/RecordsConfig.cc
>> @@ -400,7 +400,7 @@ static const RecordElement RecordsConfig[] =
>> ,
>> {RECT_CONFIG, "proxy.config.net.max_connections_in", RECD_INT,
>> "30000", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
>> ,
>> - {RECT_CONFIG, "proxy.config.net.max_requests_active_in", RECD_INT,
>> "0", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
>> + {RECT_CONFIG, "proxy.config.net.max_requests_in", RECD_INT, "0",
>> RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
>> ,
>>
>> // ###########################
>>
>> On 7/23/2020 5:16 AM, Randy DuCharame wrote:
>>>
>>> Thanks for the quick response! The build is just a couple hours
>>> old. I'm in sync with the repository or I'd build again.
>>>
>>>
>>>
>>> On 7/23/2020 5:12 AM, Damian Meden wrote:
>>>> Hello, the inclusion of that feature seems a fairly new change, how
>>>> old is your build?
>>>>
>>>> PS: The error you are getting is related to a configuration being
>>>> declared in a config file but not registered inside TS.
>>>>
>>>> Best Regards,
>>>> Damian.
>>>>
>>>> On Thu, Jul 23, 2020 at 10:34 AM Randy DuCharame <randy@ad5gb.com
>>>> <ma...@ad5gb.com>> wrote:
>>>>
>>>> Greetings,
>>>>
>>>> I'm running a build from the latest sources and am now seeing:
>>>>
>>>> "WARNING: Unrecognized configuration value
>>>> 'proxy.config.net.max_requests_in''
>>>>
>>>> showing up in diags.log. I'm not coming up with anything in
>>>> searching
>>>> but I've not yet started digging through code. I was hoping
>>>> someone
>>>> with more experience with ATS would know. :-) I'm a relative
>>>> noob to
>>>> the proxy. I've probably done something stupid but not sure what.
>>>>
>>>> Many thanks in advance!
>>>>
>>>> --
>>>> Randall DuCharme (Radio AD5GB)
>>>> Powered entirely by Open Source software.
>>>>
>>> --
>>> Randall DuCharme (Radio AD5GB)
>>> Powered entirely by Open Source software.
>> --
>> Randall DuCharme (Radio AD5GB)
>> Powered entirely by Open Source software.
>> <0x4BC19D71C1381AA3.asc>
--
Randall DuCharme (Radio AD5GB)
Powered entirely by Open Source software.
Re: Is "proxy.config.net.max_requests_in" invalid?
Posted by Sudheer Vinukonda <su...@yahoo.com>.
Ah, this looks like a bug in a change that I made recently. Thanks for reporting and fixing it. Could you pls create a PR?
> On Jul 23, 2020, at 5:21 AM, Randy DuCharame <ra...@ad5gb.com> wrote:
>
>
> Well, Damian's reply got me to scratching around in the code. Seems that the changes in the diff below fixes the warning. I guess I'll test some things to see if it does the expected thing and submit a patch. Again, I'm a NOOB when it comes to TS.
>
>
>
> diff --git a/mgmt/RecordsConfig.cc b/mgmt/RecordsConfig.cc
> index 30515e201..6059226bc 100644
> --- a/mgmt/RecordsConfig.cc
> +++ b/mgmt/RecordsConfig.cc
> @@ -400,7 +400,7 @@ static const RecordElement RecordsConfig[] =
> ,
> {RECT_CONFIG, "proxy.config.net.max_connections_in", RECD_INT, "30000", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
> ,
> - {RECT_CONFIG, "proxy.config.net.max_requests_active_in", RECD_INT, "0", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
> + {RECT_CONFIG, "proxy.config.net.max_requests_in", RECD_INT, "0", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
> ,
>
> // ###########################
>
>
> On 7/23/2020 5:16 AM, Randy DuCharame wrote:
>> Thanks for the quick response! The build is just a couple hours old. I'm in sync with the repository or I'd build again.
>>
>>
>>
>>
>>
>> On 7/23/2020 5:12 AM, Damian Meden wrote:
>>> Hello, the inclusion of that feature seems a fairly new change, how old is your build?
>>>
>>> PS: The error you are getting is related to a configuration being declared in a config file but not registered inside TS.
>>>
>>> Best Regards,
>>> Damian.
>>>
>>> On Thu, Jul 23, 2020 at 10:34 AM Randy DuCharame <ra...@ad5gb.com> wrote:
>>>> Greetings,
>>>>
>>>> I'm running a build from the latest sources and am now seeing:
>>>>
>>>> "WARNING: Unrecognized configuration value
>>>> 'proxy.config.net.max_requests_in''
>>>>
>>>> showing up in diags.log. I'm not coming up with anything in searching
>>>> but I've not yet started digging through code. I was hoping someone
>>>> with more experience with ATS would know. :-) I'm a relative noob to
>>>> the proxy. I've probably done something stupid but not sure what.
>>>>
>>>> Many thanks in advance!
>>>>
>>>> --
>>>> Randall DuCharme (Radio AD5GB)
>>>> Powered entirely by Open Source software.
>>>>
>> --
>> Randall DuCharme (Radio AD5GB)
>> Powered entirely by Open Source software.
> --
> Randall DuCharme (Radio AD5GB)
> Powered entirely by Open Source software.
> <0x4BC19D71C1381AA3.asc>
Re: Is "proxy.config.net.max_requests_in" invalid?
Posted by Randy DuCharame <ra...@ad5gb.com>.
Well, Damian's reply got me to scratching around in the code. Seems
that the changes in the diff below fixes the warning. I guess I'll test
some things to see if it does the expected thing and submit a patch.
Again, I'm a NOOB when it comes to TS.
diff --git a/mgmt/RecordsConfig.cc b/mgmt/RecordsConfig.cc
index 30515e201..6059226bc 100644
--- a/mgmt/RecordsConfig.cc
+++ b/mgmt/RecordsConfig.cc
@@ -400,7 +400,7 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG, "proxy.config.net.max_connections_in", RECD_INT,
"30000", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
,
- {RECT_CONFIG, "proxy.config.net.max_requests_active_in", RECD_INT,
"0", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
+ {RECT_CONFIG, "proxy.config.net.max_requests_in", RECD_INT, "0",
RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
,
// ###########################
On 7/23/2020 5:16 AM, Randy DuCharame wrote:
>
> Thanks for the quick response! The build is just a couple hours old.
> I'm in sync with the repository or I'd build again.
>
>
>
> On 7/23/2020 5:12 AM, Damian Meden wrote:
>> Hello, the inclusion of that feature seems a fairly new change, how
>> old is your build?
>>
>> PS: The error you are getting is related to a configuration being
>> declared in a config file but not registered inside TS.
>>
>> Best Regards,
>> Damian.
>>
>> On Thu, Jul 23, 2020 at 10:34 AM Randy DuCharame <randy@ad5gb.com
>> <ma...@ad5gb.com>> wrote:
>>
>> Greetings,
>>
>> I'm running a build from the latest sources and am now seeing:
>>
>> "WARNING: Unrecognized configuration value
>> 'proxy.config.net.max_requests_in''
>>
>> showing up in diags.log. I'm not coming up with anything in
>> searching
>> but I've not yet started digging through code. I was hoping someone
>> with more experience with ATS would know. :-) I'm a relative noob to
>> the proxy. I've probably done something stupid but not sure what.
>>
>> Many thanks in advance!
>>
>> --
>> Randall DuCharme (Radio AD5GB)
>> Powered entirely by Open Source software.
>>
> --
> Randall DuCharme (Radio AD5GB)
> Powered entirely by Open Source software.
--
Randall DuCharme (Radio AD5GB)
Powered entirely by Open Source software.
Re: Is "proxy.config.net.max_requests_in" invalid?
Posted by Randy DuCharame <ra...@ad5gb.com>.
Thanks for the quick response! The build is just a couple hours old.
I'm in sync with the repository or I'd build again.
On 7/23/2020 5:12 AM, Damian Meden wrote:
> Hello, the inclusion of that feature seems a fairly new change, how
> old is your build?
>
> PS: The error you are getting is related to a configuration being
> declared in a config file but not registered inside TS.
>
> Best Regards,
> Damian.
>
> On Thu, Jul 23, 2020 at 10:34 AM Randy DuCharame <randy@ad5gb.com
> <ma...@ad5gb.com>> wrote:
>
> Greetings,
>
> I'm running a build from the latest sources and am now seeing:
>
> "WARNING: Unrecognized configuration value
> 'proxy.config.net.max_requests_in''
>
> showing up in diags.log. I'm not coming up with anything in
> searching
> but I've not yet started digging through code. I was hoping someone
> with more experience with ATS would know. :-) I'm a relative noob to
> the proxy. I've probably done something stupid but not sure what.
>
> Many thanks in advance!
>
> --
> Randall DuCharme (Radio AD5GB)
> Powered entirely by Open Source software.
>
--
Randall DuCharme (Radio AD5GB)
Powered entirely by Open Source software.
Re: Is "proxy.config.net.max_requests_in" invalid?
Posted by Damian Meden <da...@verizonmedia.com>.
Hello, the inclusion of that feature seems a fairly new change, how old is
your build?
PS: The error you are getting is related to a configuration being declared
in a config file but not registered inside TS.
Best Regards,
Damian.
On Thu, Jul 23, 2020 at 10:34 AM Randy DuCharame <ra...@ad5gb.com> wrote:
> Greetings,
>
> I'm running a build from the latest sources and am now seeing:
>
> "WARNING: Unrecognized configuration value
> 'proxy.config.net.max_requests_in''
>
> showing up in diags.log. I'm not coming up with anything in searching
> but I've not yet started digging through code. I was hoping someone
> with more experience with ATS would know. :-) I'm a relative noob to
> the proxy. I've probably done something stupid but not sure what.
>
> Many thanks in advance!
>
> --
> Randall DuCharme (Radio AD5GB)
> Powered entirely by Open Source software.
>
>