You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/01/11 22:49:03 UTC
[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #513: SOLR-9376: [xml] and [json] RawValue DocTransformers should work in cloud mode
sonatype-lift[bot] commented on a change in pull request #513:
URL: https://github.com/apache/solr/pull/513#discussion_r782583430
##########
File path: solr/core/src/java/org/apache/solr/response/JSONWriter.java
##########
@@ -41,14 +43,15 @@ public JSONWriter(Writer writer, SolrQueryRequest req, SolrQueryResponse rsp) {
public JSONWriter(Writer writer, SolrQueryRequest req, SolrQueryResponse rsp,
String wrapperFunction, String namedListStyle) {
- super(writer, req, rsp);
+ super(writer, req, rsp, getRawFields(req, rsp, "json"));
this.wrapperFunction = wrapperFunction;
this.namedListStyle = namedListStyle;
+ final String wt = req.getParams().get(CommonParams.WT);
+ final ReturnFields topLevelReturnFields = rsp.getReturnFields();
Review comment:
*UnusedVariable:* The local variable 'topLevelReturnFields' is never read. [(details)](https://errorprone.info/bugpattern/UnusedVariable)
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)
##########
File path: solr/core/src/java/org/apache/solr/response/JSONWriter.java
##########
@@ -41,14 +43,15 @@ public JSONWriter(Writer writer, SolrQueryRequest req, SolrQueryResponse rsp) {
public JSONWriter(Writer writer, SolrQueryRequest req, SolrQueryResponse rsp,
String wrapperFunction, String namedListStyle) {
- super(writer, req, rsp);
+ super(writer, req, rsp, getRawFields(req, rsp, "json"));
this.wrapperFunction = wrapperFunction;
this.namedListStyle = namedListStyle;
+ final String wt = req.getParams().get(CommonParams.WT);
Review comment:
*UnusedVariable:* The local variable 'wt' is never read. [(details)](https://errorprone.info/bugpattern/UnusedVariable)
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org