You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/12/07 08:19:57 UTC

[GitHub] [maven-jlink-plugin] sparsick commented on a change in pull request #19: [MJLINK-58] Remove usage of plexus utils, use commons lang or native …

sparsick commented on a change in pull request #19:
URL: https://github.com/apache/maven-jlink-plugin/pull/19#discussion_r537309765



##########
File path: pom.xml
##########
@@ -109,6 +109,11 @@
       <artifactId>commons-lang3</artifactId>
       <version>3.6</version>
     </dependency>
+    <dependency>

Review comment:
       @bmarwell What do you mean with "drop commons altogether"? Do you want to remove them from the pom? If so, I wouldn't recommend it because they are used in the plugin and therefore, they should be explicitly named in the pom.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org