You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/08 06:56:12 UTC
[GitHub] [flink] lirui-apache opened a new pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
lirui-apache opened a new pull request #12029:
URL: https://github.com/apache/flink/pull/12029
…DLs for Hive dialect
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Implement view DDLs for Hive dialect.
## Brief change log
- Implement view DDL syntax for hive dialect.
- Add SqlNodes for ALTER VIEW statements.
- Add AlterOperation for ALTER VIEW AS statement.
- Update `SqlToOperationConverter` and `TableEnvironmentImpl` to support alter view operations.
- Add test cases.
## Verifying this change
Existing and added tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? docs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
}, {
"hash" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"triggerType" : "PUSH"
}, {
"hash" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263",
"triggerID" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"triggerType" : "PUSH"
}, {
"hash" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1380",
"triggerID" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"triggerType" : "PUSH"
}, {
"hash" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9405ea4470dc022ffb514f603396fc6bb2582835 UNKNOWN
* b780f3a3a0fa439dbe49af89cca228c735931d1b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1380)
* 7710f1698ed5a88b5947b61cc9498ad1b825a1b4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 99f2de48a8669c53c60a95442a68656abb3472fe Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
}, {
"hash" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"triggerType" : "PUSH"
}, {
"hash" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263",
"triggerID" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"triggerType" : "PUSH"
}, {
"hash" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1380",
"triggerID" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"triggerType" : "PUSH"
}, {
"hash" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1400",
"triggerID" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"triggerType" : "PUSH"
}, {
"hash" : "0ea67ded38cbd339a5f67656b50b874625a911b9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0ea67ded38cbd339a5f67656b50b874625a911b9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9405ea4470dc022ffb514f603396fc6bb2582835 UNKNOWN
* 7710f1698ed5a88b5947b61cc9498ad1b825a1b4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1400)
* 0ea67ded38cbd339a5f67656b50b874625a911b9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625668720
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit cbf5ef6f14500b63eafb43901b3efa6db28c22b2 (Fri Oct 16 10:33:58 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KurtYoung closed pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
KurtYoung closed pull request #12029:
URL: https://github.com/apache/flink/pull/12029
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
}, {
"hash" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"triggerType" : "PUSH"
}, {
"hash" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263",
"triggerID" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"triggerType" : "PUSH"
}, {
"hash" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1380",
"triggerID" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"triggerType" : "PUSH"
}, {
"hash" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1400",
"triggerID" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"triggerType" : "PUSH"
}, {
"hash" : "0ea67ded38cbd339a5f67656b50b874625a911b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1494",
"triggerID" : "0ea67ded38cbd339a5f67656b50b874625a911b9",
"triggerType" : "PUSH"
}, {
"hash" : "abf3481dcb850de081a045ae96d27c335e96e157",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1523",
"triggerID" : "abf3481dcb850de081a045ae96d27c335e96e157",
"triggerType" : "PUSH"
}, {
"hash" : "c1ad4b5d93e10b76fad14269f46fa62e4d771bed",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1554",
"triggerID" : "c1ad4b5d93e10b76fad14269f46fa62e4d771bed",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9405ea4470dc022ffb514f603396fc6bb2582835 UNKNOWN
* abf3481dcb850de081a045ae96d27c335e96e157 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1523)
* c1ad4b5d93e10b76fad14269f46fa62e4d771bed Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1554)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KurtYoung commented on a change in pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #12029:
URL: https://github.com/apache/flink/pull/12029#discussion_r426130612
##########
File path: flink-table/flink-sql-parser-hive/src/test/java/org/apache/flink/sql/parser/hive/FlinkHiveSqlParserImplTest.java
##########
@@ -221,4 +221,49 @@ public void testInsert() {
"(SELECT *\n" +
"FROM `SRC`)");
}
+
+ @Test
+ public void testCreateView() {
+ sql("create view db1.v1 as select x,y from tbl")
+ .ok("CREATE VIEW `DB1`.`V1`\n" +
+ "AS\n" +
+ "SELECT `X`, `Y`\n" +
+ "FROM `TBL`");
+ sql("create view if not exists v1 (c1,c2) as select * from tbl")
+ .ok("CREATE VIEW IF NOT EXISTS `V1` (`C1`, `C2`)\n" +
+ "AS\n" +
+ "SELECT *\n" +
+ "FROM `TBL`");
+ sql("create view v1 comment 'v1 comment' tblproperties('k1'='v1','k2'='v2') as select * from tbl")
+ .ok("CREATE VIEW `V1`\n" +
+ "COMMENT 'v1 comment'\n" +
+ "TBLPROPERTIES (\n" +
+ " 'k1' = 'v1',\n" +
+ " 'k2' = 'v2'\n" +
+ ")\n" +
+ "AS\n" +
+ "SELECT *\n" +
+ "FROM `TBL`");
+ // TODO: support column comments
Review comment:
will column comment supported in 1.11?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
}, {
"hash" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"triggerType" : "PUSH"
}, {
"hash" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263",
"triggerID" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"triggerType" : "PUSH"
}, {
"hash" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9405ea4470dc022ffb514f603396fc6bb2582835 UNKNOWN
* 3d1878cdf4c0a955e56b68d02bb743e5d6b78317 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263)
* b780f3a3a0fa439dbe49af89cca228c735931d1b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
}, {
"hash" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"triggerType" : "PUSH"
}, {
"hash" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 99f2de48a8669c53c60a95442a68656abb3472fe Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877)
* 9405ea4470dc022ffb514f603396fc6bb2582835 UNKNOWN
* 3d1878cdf4c0a955e56b68d02bb743e5d6b78317 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6933a873ba179bc9dba26843a44c2bc72f1d95f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800)
* 99f2de48a8669c53c60a95442a68656abb3472fe UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
}, {
"hash" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"triggerType" : "PUSH"
}, {
"hash" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263",
"triggerID" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"triggerType" : "PUSH"
}, {
"hash" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1380",
"triggerID" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"triggerType" : "PUSH"
}, {
"hash" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1400",
"triggerID" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"triggerType" : "PUSH"
}, {
"hash" : "0ea67ded38cbd339a5f67656b50b874625a911b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1494",
"triggerID" : "0ea67ded38cbd339a5f67656b50b874625a911b9",
"triggerType" : "PUSH"
}, {
"hash" : "abf3481dcb850de081a045ae96d27c335e96e157",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1523",
"triggerID" : "abf3481dcb850de081a045ae96d27c335e96e157",
"triggerType" : "PUSH"
}, {
"hash" : "c1ad4b5d93e10b76fad14269f46fa62e4d771bed",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1554",
"triggerID" : "c1ad4b5d93e10b76fad14269f46fa62e4d771bed",
"triggerType" : "PUSH"
}, {
"hash" : "cbf5ef6f14500b63eafb43901b3efa6db28c22b2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1586",
"triggerID" : "cbf5ef6f14500b63eafb43901b3efa6db28c22b2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9405ea4470dc022ffb514f603396fc6bb2582835 UNKNOWN
* c1ad4b5d93e10b76fad14269f46fa62e4d771bed Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1554)
* cbf5ef6f14500b63eafb43901b3efa6db28c22b2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1586)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
}, {
"hash" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"triggerType" : "PUSH"
}, {
"hash" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263",
"triggerID" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"triggerType" : "PUSH"
}, {
"hash" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1380",
"triggerID" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"triggerType" : "PUSH"
}, {
"hash" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1400",
"triggerID" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9405ea4470dc022ffb514f603396fc6bb2582835 UNKNOWN
* 7710f1698ed5a88b5947b61cc9498ad1b825a1b4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1400)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KurtYoung commented on a change in pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #12029:
URL: https://github.com/apache/flink/pull/12029#discussion_r426207410
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/AlterTablePropertiesOperation.java
##########
@@ -26,27 +27,28 @@
/**
- * Operation to describe a ALTER TABLE .. SET .. statement.
+ * Operation to describe a ALTER TABLE/VIEW .. SET .. statement.
*/
public class AlterTablePropertiesOperation extends AlterTableOperation {
Review comment:
Create a dedicated `AlterViewPropertiesOperation` and extends from `AlterViewOperation`
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/AlterViewAsOperation.java
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.operations.ddl;
+
+import org.apache.flink.table.catalog.CatalogView;
+import org.apache.flink.table.catalog.ObjectIdentifier;
+
+/**
+ * Operation to describe an ALTER VIEW ... AS ... statement.
+ */
+public class AlterViewAsOperation extends AlterTableOperation {
Review comment:
create a base class `AlterViewOperation` and extends from that, `AlterViewOperation` should be the same level of `AlterTableOperation `
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/operations/SqlToOperationConverter.java
##########
@@ -227,86 +234,134 @@ private Operation convertDropTable(SqlDropTable sqlDropTable) {
return new DropTableOperation(identifier, sqlDropTable.getIfExists(), sqlDropTable.isTemporary());
}
+ /**
+ * convert ALTER VIEW statement.
+ */
+ private Operation convertAlterView(SqlAlterView alterView) {
+ UnresolvedIdentifier unresolvedIdentifier = UnresolvedIdentifier.of(alterView.fullViewName());
+ ObjectIdentifier viewIdentifier = catalogManager.qualifyIdentifier(unresolvedIdentifier);
+ Optional<CatalogManager.TableLookupResult> optionalCatalogTable = catalogManager.getTable(viewIdentifier);
+ if (!optionalCatalogTable.isPresent() || optionalCatalogTable.get().isTemporary()) {
+ throw new ValidationException(String.format("View %s doesn't exist or is a temporary view.",
+ viewIdentifier.toString()));
+ }
+ CatalogBaseTable baseTable = optionalCatalogTable.get().getTable();
+ if (baseTable instanceof CatalogTable) {
+ throw new ValidationException("ALTER VIEW for a table is not allowed");
+ }
+ if (alterView instanceof SqlAlterViewRename) {
+ UnresolvedIdentifier newUnresolvedIdentifier =
+ UnresolvedIdentifier.of(((SqlAlterViewRename) alterView).fullNewViewName());
+ ObjectIdentifier newTableIdentifier = catalogManager.qualifyIdentifier(newUnresolvedIdentifier);
+ return new AlterTableRenameOperation(viewIdentifier, newTableIdentifier);
Review comment:
create a new `AlterViewRenameOperation`
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/operations/SqlToOperationConverter.java
##########
@@ -227,86 +234,134 @@ private Operation convertDropTable(SqlDropTable sqlDropTable) {
return new DropTableOperation(identifier, sqlDropTable.getIfExists(), sqlDropTable.isTemporary());
}
+ /**
+ * convert ALTER VIEW statement.
+ */
+ private Operation convertAlterView(SqlAlterView alterView) {
+ UnresolvedIdentifier unresolvedIdentifier = UnresolvedIdentifier.of(alterView.fullViewName());
+ ObjectIdentifier viewIdentifier = catalogManager.qualifyIdentifier(unresolvedIdentifier);
+ Optional<CatalogManager.TableLookupResult> optionalCatalogTable = catalogManager.getTable(viewIdentifier);
+ if (!optionalCatalogTable.isPresent() || optionalCatalogTable.get().isTemporary()) {
+ throw new ValidationException(String.format("View %s doesn't exist or is a temporary view.",
+ viewIdentifier.toString()));
+ }
+ CatalogBaseTable baseTable = optionalCatalogTable.get().getTable();
+ if (baseTable instanceof CatalogTable) {
+ throw new ValidationException("ALTER VIEW for a table is not allowed");
+ }
+ if (alterView instanceof SqlAlterViewRename) {
+ UnresolvedIdentifier newUnresolvedIdentifier =
+ UnresolvedIdentifier.of(((SqlAlterViewRename) alterView).fullNewViewName());
+ ObjectIdentifier newTableIdentifier = catalogManager.qualifyIdentifier(newUnresolvedIdentifier);
+ return new AlterTableRenameOperation(viewIdentifier, newTableIdentifier);
+ } else if (alterView instanceof SqlAlterViewProperties) {
+ SqlAlterViewProperties alterViewProperties = (SqlAlterViewProperties) alterView;
+ CatalogView oldView = (CatalogView) baseTable;
+ Map<String, String> newProperties = new HashMap<>(oldView.getOptions());
+ newProperties.putAll(extractProperties(alterViewProperties.getPropertyList()));
+ CatalogView newView = new CatalogViewImpl(
+ oldView.getOriginalQuery(),
+ oldView.getExpandedQuery(),
+ oldView.getSchema(),
+ newProperties,
+ oldView.getComment());
+ return new AlterTablePropertiesOperation(viewIdentifier, newView);
Review comment:
don't reuse `AlterTablePropertiesOperation `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lirui-apache commented on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625690870
@JingsongLi @danny0405 Please have a look. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
}, {
"hash" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"triggerType" : "PUSH"
}, {
"hash" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263",
"triggerID" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"triggerType" : "PUSH"
}, {
"hash" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1380",
"triggerID" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"triggerType" : "PUSH"
}, {
"hash" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1400",
"triggerID" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"triggerType" : "PUSH"
}, {
"hash" : "0ea67ded38cbd339a5f67656b50b874625a911b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1494",
"triggerID" : "0ea67ded38cbd339a5f67656b50b874625a911b9",
"triggerType" : "PUSH"
}, {
"hash" : "abf3481dcb850de081a045ae96d27c335e96e157",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1523",
"triggerID" : "abf3481dcb850de081a045ae96d27c335e96e157",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9405ea4470dc022ffb514f603396fc6bb2582835 UNKNOWN
* abf3481dcb850de081a045ae96d27c335e96e157 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1523)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KurtYoung commented on a change in pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #12029:
URL: https://github.com/apache/flink/pull/12029#discussion_r426108333
##########
File path: flink-table/flink-sql-parser-hive/src/main/codegen/includes/parserImpls.ftl
##########
@@ -958,3 +958,90 @@ void TableApiIdentifierSegment(List<String> names, List<SqlParserPos> positions)
}
}
}
+
+/* Parses a create view or replace existing view statement.
+ * CREATE [OR REPLACE] VIEW view_name [ (field1, field2 ...) ] AS select_statement
Review comment:
Provide an example in hive dialect
##########
File path: flink-table/flink-sql-parser-hive/src/main/codegen/includes/parserImpls.ftl
##########
@@ -958,3 +958,90 @@ void TableApiIdentifierSegment(List<String> names, List<SqlParserPos> positions)
}
}
}
+
+/* Parses a create view or replace existing view statement.
+ * CREATE [OR REPLACE] VIEW view_name [ (field1, field2 ...) ] AS select_statement
Review comment:
BTW, I think it's better to copy and paste some hive's DDL LanguageManual to each supported statement kind.
##########
File path: flink-table/flink-sql-parser-hive/src/main/java/org/apache/flink/sql/parser/hive/ddl/SqlCreateHiveView.java
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.sql.parser.hive.ddl;
+
+import org.apache.flink.sql.parser.ddl.SqlCreateView;
+import org.apache.flink.table.catalog.config.CatalogConfig;
+
+import org.apache.calcite.sql.SqlCharStringLiteral;
+import org.apache.calcite.sql.SqlIdentifier;
+import org.apache.calcite.sql.SqlNode;
+import org.apache.calcite.sql.SqlNodeList;
+import org.apache.calcite.sql.SqlWriter;
+import org.apache.calcite.sql.parser.SqlParserPos;
+
+/**
+ * CREATE View DDL for Hive dialect.
Review comment:
put hive's Language Manual here, easier for us to check whether this class make sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
}, {
"hash" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"triggerType" : "PUSH"
}, {
"hash" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263",
"triggerID" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"triggerType" : "PUSH"
}, {
"hash" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1380",
"triggerID" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9405ea4470dc022ffb514f603396fc6bb2582835 UNKNOWN
* b780f3a3a0fa439dbe49af89cca228c735931d1b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1380)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6933a873ba179bc9dba26843a44c2bc72f1d95f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800)
* 99f2de48a8669c53c60a95442a68656abb3472fe Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
}, {
"hash" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"triggerType" : "PUSH"
}, {
"hash" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263",
"triggerID" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"triggerType" : "PUSH"
}, {
"hash" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1380",
"triggerID" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"triggerType" : "PUSH"
}, {
"hash" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1400",
"triggerID" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"triggerType" : "PUSH"
}, {
"hash" : "0ea67ded38cbd339a5f67656b50b874625a911b9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1494",
"triggerID" : "0ea67ded38cbd339a5f67656b50b874625a911b9",
"triggerType" : "PUSH"
}, {
"hash" : "abf3481dcb850de081a045ae96d27c335e96e157",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1523",
"triggerID" : "abf3481dcb850de081a045ae96d27c335e96e157",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9405ea4470dc022ffb514f603396fc6bb2582835 UNKNOWN
* 0ea67ded38cbd339a5f67656b50b874625a911b9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1494)
* abf3481dcb850de081a045ae96d27c335e96e157 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1523)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
}, {
"hash" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"triggerType" : "PUSH"
}, {
"hash" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263",
"triggerID" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"triggerType" : "PUSH"
}, {
"hash" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1380",
"triggerID" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"triggerType" : "PUSH"
}, {
"hash" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1400",
"triggerID" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"triggerType" : "PUSH"
}, {
"hash" : "0ea67ded38cbd339a5f67656b50b874625a911b9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1494",
"triggerID" : "0ea67ded38cbd339a5f67656b50b874625a911b9",
"triggerType" : "PUSH"
}, {
"hash" : "abf3481dcb850de081a045ae96d27c335e96e157",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "abf3481dcb850de081a045ae96d27c335e96e157",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9405ea4470dc022ffb514f603396fc6bb2582835 UNKNOWN
* 0ea67ded38cbd339a5f67656b50b874625a911b9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1494)
* abf3481dcb850de081a045ae96d27c335e96e157 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
}, {
"hash" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"triggerType" : "PUSH"
}, {
"hash" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263",
"triggerID" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"triggerType" : "PUSH"
}, {
"hash" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1380",
"triggerID" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9405ea4470dc022ffb514f603396fc6bb2582835 UNKNOWN
* 3d1878cdf4c0a955e56b68d02bb743e5d6b78317 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263)
* b780f3a3a0fa439dbe49af89cca228c735931d1b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1380)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6933a873ba179bc9dba26843a44c2bc72f1d95f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
}, {
"hash" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"triggerType" : "PUSH"
}, {
"hash" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263",
"triggerID" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"triggerType" : "PUSH"
}, {
"hash" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1380",
"triggerID" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"triggerType" : "PUSH"
}, {
"hash" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1400",
"triggerID" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"triggerType" : "PUSH"
}, {
"hash" : "0ea67ded38cbd339a5f67656b50b874625a911b9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1494",
"triggerID" : "0ea67ded38cbd339a5f67656b50b874625a911b9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9405ea4470dc022ffb514f603396fc6bb2582835 UNKNOWN
* 7710f1698ed5a88b5947b61cc9498ad1b825a1b4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1400)
* 0ea67ded38cbd339a5f67656b50b874625a911b9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1494)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
}, {
"hash" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"triggerType" : "PUSH"
}, {
"hash" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263",
"triggerID" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9405ea4470dc022ffb514f603396fc6bb2582835 UNKNOWN
* 3d1878cdf4c0a955e56b68d02bb743e5d6b78317 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
}, {
"hash" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"triggerType" : "PUSH"
}, {
"hash" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263",
"triggerID" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"triggerType" : "PUSH"
}, {
"hash" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1380",
"triggerID" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"triggerType" : "PUSH"
}, {
"hash" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1400",
"triggerID" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"triggerType" : "PUSH"
}, {
"hash" : "0ea67ded38cbd339a5f67656b50b874625a911b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1494",
"triggerID" : "0ea67ded38cbd339a5f67656b50b874625a911b9",
"triggerType" : "PUSH"
}, {
"hash" : "abf3481dcb850de081a045ae96d27c335e96e157",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1523",
"triggerID" : "abf3481dcb850de081a045ae96d27c335e96e157",
"triggerType" : "PUSH"
}, {
"hash" : "c1ad4b5d93e10b76fad14269f46fa62e4d771bed",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1554",
"triggerID" : "c1ad4b5d93e10b76fad14269f46fa62e4d771bed",
"triggerType" : "PUSH"
}, {
"hash" : "cbf5ef6f14500b63eafb43901b3efa6db28c22b2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cbf5ef6f14500b63eafb43901b3efa6db28c22b2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9405ea4470dc022ffb514f603396fc6bb2582835 UNKNOWN
* c1ad4b5d93e10b76fad14269f46fa62e4d771bed Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1554)
* cbf5ef6f14500b63eafb43901b3efa6db28c22b2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
}, {
"hash" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"triggerType" : "PUSH"
}, {
"hash" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263",
"triggerID" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"triggerType" : "PUSH"
}, {
"hash" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1380",
"triggerID" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"triggerType" : "PUSH"
}, {
"hash" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1400",
"triggerID" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"triggerType" : "PUSH"
}, {
"hash" : "0ea67ded38cbd339a5f67656b50b874625a911b9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1494",
"triggerID" : "0ea67ded38cbd339a5f67656b50b874625a911b9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9405ea4470dc022ffb514f603396fc6bb2582835 UNKNOWN
* 0ea67ded38cbd339a5f67656b50b874625a911b9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1494)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lirui-apache commented on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-629632721
The `test_ci tests` failure shouldn't be related because it has passed in my personal build:
https://dev.azure.com/lirui-apache/flink/_build/results?buildId=61&view=results
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6933a873ba179bc9dba26843a44c2bc72f1d95f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6933a873ba179bc9dba26843a44c2bc72f1d95f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lirui-apache commented on a change in pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #12029:
URL: https://github.com/apache/flink/pull/12029#discussion_r426135660
##########
File path: flink-table/flink-sql-parser-hive/src/test/java/org/apache/flink/sql/parser/hive/FlinkHiveSqlParserImplTest.java
##########
@@ -221,4 +221,49 @@ public void testInsert() {
"(SELECT *\n" +
"FROM `SRC`)");
}
+
+ @Test
+ public void testCreateView() {
+ sql("create view db1.v1 as select x,y from tbl")
+ .ok("CREATE VIEW `DB1`.`V1`\n" +
+ "AS\n" +
+ "SELECT `X`, `Y`\n" +
+ "FROM `TBL`");
+ sql("create view if not exists v1 (c1,c2) as select * from tbl")
+ .ok("CREATE VIEW IF NOT EXISTS `V1` (`C1`, `C2`)\n" +
+ "AS\n" +
+ "SELECT *\n" +
+ "FROM `TBL`");
+ sql("create view v1 comment 'v1 comment' tblproperties('k1'='v1','k2'='v2') as select * from tbl")
+ .ok("CREATE VIEW `V1`\n" +
+ "COMMENT 'v1 comment'\n" +
+ "TBLPROPERTIES (\n" +
+ " 'k1' = 'v1',\n" +
+ " 'k2' = 'v2'\n" +
+ ")\n" +
+ "AS\n" +
+ "SELECT *\n" +
+ "FROM `TBL`");
+ // TODO: support column comments
Review comment:
I'm afraid not. Actually table's column comment is not supported neither. The comments get discarded when converted to `TableSchema`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
}, {
"hash" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"triggerType" : "PUSH"
}, {
"hash" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263",
"triggerID" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"triggerType" : "PUSH"
}, {
"hash" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1380",
"triggerID" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"triggerType" : "PUSH"
}, {
"hash" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1400",
"triggerID" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"triggerType" : "PUSH"
}, {
"hash" : "0ea67ded38cbd339a5f67656b50b874625a911b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1494",
"triggerID" : "0ea67ded38cbd339a5f67656b50b874625a911b9",
"triggerType" : "PUSH"
}, {
"hash" : "abf3481dcb850de081a045ae96d27c335e96e157",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1523",
"triggerID" : "abf3481dcb850de081a045ae96d27c335e96e157",
"triggerType" : "PUSH"
}, {
"hash" : "c1ad4b5d93e10b76fad14269f46fa62e4d771bed",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1554",
"triggerID" : "c1ad4b5d93e10b76fad14269f46fa62e4d771bed",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9405ea4470dc022ffb514f603396fc6bb2582835 UNKNOWN
* c1ad4b5d93e10b76fad14269f46fa62e4d771bed Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1554)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
}, {
"hash" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"triggerType" : "PUSH"
}, {
"hash" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263",
"triggerID" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 99f2de48a8669c53c60a95442a68656abb3472fe Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877)
* 9405ea4470dc022ffb514f603396fc6bb2582835 UNKNOWN
* 3d1878cdf4c0a955e56b68d02bb743e5d6b78317 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625668720
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f6933a873ba179bc9dba26843a44c2bc72f1d95f (Fri May 08 06:59:10 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17451).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
}, {
"hash" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"triggerType" : "PUSH"
}, {
"hash" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263",
"triggerID" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"triggerType" : "PUSH"
}, {
"hash" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1380",
"triggerID" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"triggerType" : "PUSH"
}, {
"hash" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1400",
"triggerID" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9405ea4470dc022ffb514f603396fc6bb2582835 UNKNOWN
* b780f3a3a0fa439dbe49af89cca228c735931d1b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1380)
* 7710f1698ed5a88b5947b61cc9498ad1b825a1b4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1400)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lirui-apache commented on a change in pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #12029:
URL: https://github.com/apache/flink/pull/12029#discussion_r426113993
##########
File path: flink-table/flink-sql-parser-hive/src/main/codegen/includes/parserImpls.ftl
##########
@@ -958,3 +958,90 @@ void TableApiIdentifierSegment(List<String> names, List<SqlParserPos> positions)
}
}
}
+
+/* Parses a create view or replace existing view statement.
+ * CREATE [OR REPLACE] VIEW view_name [ (field1, field2 ...) ] AS select_statement
Review comment:
I have added Hive syntax in the comments. Note that some features are not yet supported, e.g. column comments for views.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
}, {
"hash" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"triggerType" : "PUSH"
}, {
"hash" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1263",
"triggerID" : "3d1878cdf4c0a955e56b68d02bb743e5d6b78317",
"triggerType" : "PUSH"
}, {
"hash" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1380",
"triggerID" : "b780f3a3a0fa439dbe49af89cca228c735931d1b",
"triggerType" : "PUSH"
}, {
"hash" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1400",
"triggerID" : "7710f1698ed5a88b5947b61cc9498ad1b825a1b4",
"triggerType" : "PUSH"
}, {
"hash" : "0ea67ded38cbd339a5f67656b50b874625a911b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1494",
"triggerID" : "0ea67ded38cbd339a5f67656b50b874625a911b9",
"triggerType" : "PUSH"
}, {
"hash" : "abf3481dcb850de081a045ae96d27c335e96e157",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1523",
"triggerID" : "abf3481dcb850de081a045ae96d27c335e96e157",
"triggerType" : "PUSH"
}, {
"hash" : "c1ad4b5d93e10b76fad14269f46fa62e4d771bed",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c1ad4b5d93e10b76fad14269f46fa62e4d771bed",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9405ea4470dc022ffb514f603396fc6bb2582835 UNKNOWN
* abf3481dcb850de081a045ae96d27c335e96e157 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1523)
* c1ad4b5d93e10b76fad14269f46fa62e4d771bed UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12029:
URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=800",
"triggerID" : "f6933a873ba179bc9dba26843a44c2bc72f1d95f",
"triggerType" : "PUSH"
}, {
"hash" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877",
"triggerID" : "99f2de48a8669c53c60a95442a68656abb3472fe",
"triggerType" : "PUSH"
}, {
"hash" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9405ea4470dc022ffb514f603396fc6bb2582835",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 99f2de48a8669c53c60a95442a68656abb3472fe Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=877)
* 9405ea4470dc022ffb514f603396fc6bb2582835 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org