You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/10/20 18:45:21 UTC

Review Request 39486: Ambari to install/manage Slider tarball to HDFS

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39486/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-13383
    https://issues.apache.org/jira/browse/AMBARI-13383


Repository: ambari


Description
-------

The following command needs to be invoked (as user hdfs) after the slider
client is installed -

    
    
    
    slider dependency --upload
    

When called in an HDP cluster it will upload the Slider dependency tarball in
an HDP specific path -

    
    
    
    /hdp/apps/<hdp_version>/slider/slider.tar.gz
    

instead of

    
    
    
    /apps/<slider_version>/slider/slider.tar.gz
    

If Ambari wants to upload the tarball without using the slider command-line,
then the tarball needs to be created by packaging all jar files under
`/usr/hdp/current/slider-client/lib/`, except the `slider-core*.jar` file.


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py badf2fe 
  ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params_linux.py 5d60e21 
  ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/service_check.py 18711d7 
  ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider.py a802c19 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 5fe8157 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 6901f62 
  ambari-server/src/test/python/stacks/2.2/SLIDER/test_slider_client.py 3af55f6 

Diff: https://reviews.apache.org/r/39486/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 39486: Ambari to install/manage Slider tarball to HDFS

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39486/#review103270
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Oct. 20, 2015, 7:45 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39486/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 7:45 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-13383
>     https://issues.apache.org/jira/browse/AMBARI-13383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The following command needs to be invoked (as user hdfs) after the slider
> client is installed -
> 
>     
>     
>     
>     slider dependency --upload
>     
> 
> When called in an HDP cluster it will upload the Slider dependency tarball in
> an HDP specific path -
> 
>     
>     
>     
>     /hdp/apps/<hdp_version>/slider/slider.tar.gz
>     
> 
> instead of
> 
>     
>     
>     
>     /apps/<slider_version>/slider/slider.tar.gz
>     
> 
> If Ambari wants to upload the tarball without using the slider command-line,
> then the tarball needs to be created by packaging all jar files under
> `/usr/hdp/current/slider-client/lib/`, except the `slider-core*.jar` file.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py badf2fe 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params_linux.py 5d60e21 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/service_check.py 18711d7 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider.py a802c19 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 5fe8157 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 6901f62 
>   ambari-server/src/test/python/stacks/2.2/SLIDER/test_slider_client.py 3af55f6 
> 
> Diff: https://reviews.apache.org/r/39486/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 39486: Ambari to install/manage Slider tarball to HDFS

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39486/#review103271
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Oct. 20, 2015, 7:52 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39486/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 7:52 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-13383
>     https://issues.apache.org/jira/browse/AMBARI-13383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The following command needs to be invoked (as user hdfs) after the slider
> client is installed -
> 
>     
>     
>     
>     slider dependency --upload
>     
> 
> When called in an HDP cluster it will upload the Slider dependency tarball in
> an HDP specific path -
> 
>     
>     
>     
>     /hdp/apps/<hdp_version>/slider/slider.tar.gz
>     
> 
> instead of
> 
>     
>     
>     
>     /apps/<slider_version>/slider/slider.tar.gz
>     
> 
> If Ambari wants to upload the tarball without using the slider command-line,
> then the tarball needs to be created by packaging all jar files under
> `/usr/hdp/current/slider-client/lib/`, except the `slider-core*.jar` file.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py badf2fe 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params_linux.py 5d60e21 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/service_check.py 18711d7 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider.py a802c19 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 5fe8157 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 7549b68 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 6901f62 
>   ambari-server/src/test/python/stacks/2.2/SLIDER/test_slider_client.py 3af55f6 
> 
> Diff: https://reviews.apache.org/r/39486/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 39486: Ambari to install/manage Slider tarball to HDFS

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39486/#review103278
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On Oct. 20, 2015, 4:52 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39486/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 4:52 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-13383
>     https://issues.apache.org/jira/browse/AMBARI-13383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The following command needs to be invoked (as user hdfs) after the slider
> client is installed -
> 
>     
>     
>     
>     slider dependency --upload
>     
> 
> When called in an HDP cluster it will upload the Slider dependency tarball in
> an HDP specific path -
> 
>     
>     
>     
>     /hdp/apps/<hdp_version>/slider/slider.tar.gz
>     
> 
> instead of
> 
>     
>     
>     
>     /apps/<slider_version>/slider/slider.tar.gz
>     
> 
> If Ambari wants to upload the tarball without using the slider command-line,
> then the tarball needs to be created by packaging all jar files under
> `/usr/hdp/current/slider-client/lib/`, except the `slider-core*.jar` file.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py badf2fe 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params_linux.py 5d60e21 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/service_check.py 18711d7 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider.py a802c19 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 5fe8157 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 7549b68 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 6901f62 
>   ambari-server/src/test/python/stacks/2.2/SLIDER/test_slider_client.py 3af55f6 
> 
> Diff: https://reviews.apache.org/r/39486/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 39486: Ambari to install/manage Slider tarball to HDFS

Posted by Andrew Onischuk <ao...@hortonworks.com>.

> On Oct. 20, 2015, 5:28 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider.py, line 84
> > <https://reviews.apache.org/r/39486/diff/2/?file=1102037#file1102037line84>
> >
> >     Why is slider-core excluded?

This step was included as a part of instruction for building slider.tar.gz, given by reporter.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39486/#review103277
-----------------------------------------------------------


On Oct. 20, 2015, 4:52 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39486/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 4:52 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-13383
>     https://issues.apache.org/jira/browse/AMBARI-13383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The following command needs to be invoked (as user hdfs) after the slider
> client is installed -
> 
>     
>     
>     
>     slider dependency --upload
>     
> 
> When called in an HDP cluster it will upload the Slider dependency tarball in
> an HDP specific path -
> 
>     
>     
>     
>     /hdp/apps/<hdp_version>/slider/slider.tar.gz
>     
> 
> instead of
> 
>     
>     
>     
>     /apps/<slider_version>/slider/slider.tar.gz
>     
> 
> If Ambari wants to upload the tarball without using the slider command-line,
> then the tarball needs to be created by packaging all jar files under
> `/usr/hdp/current/slider-client/lib/`, except the `slider-core*.jar` file.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py badf2fe 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params_linux.py 5d60e21 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/service_check.py 18711d7 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider.py a802c19 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 5fe8157 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 7549b68 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 6901f62 
>   ambari-server/src/test/python/stacks/2.2/SLIDER/test_slider_client.py 3af55f6 
> 
> Diff: https://reviews.apache.org/r/39486/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 39486: Ambari to install/manage Slider tarball to HDFS

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39486/#review103277
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider.py (line 84)
<https://reviews.apache.org/r/39486/#comment161267>

    Why is slider-core excluded?


- Sumit Mohanty


On Oct. 20, 2015, 4:52 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39486/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 4:52 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-13383
>     https://issues.apache.org/jira/browse/AMBARI-13383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The following command needs to be invoked (as user hdfs) after the slider
> client is installed -
> 
>     
>     
>     
>     slider dependency --upload
>     
> 
> When called in an HDP cluster it will upload the Slider dependency tarball in
> an HDP specific path -
> 
>     
>     
>     
>     /hdp/apps/<hdp_version>/slider/slider.tar.gz
>     
> 
> instead of
> 
>     
>     
>     
>     /apps/<slider_version>/slider/slider.tar.gz
>     
> 
> If Ambari wants to upload the tarball without using the slider command-line,
> then the tarball needs to be created by packaging all jar files under
> `/usr/hdp/current/slider-client/lib/`, except the `slider-core*.jar` file.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py badf2fe 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params_linux.py 5d60e21 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/service_check.py 18711d7 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider.py a802c19 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 5fe8157 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 7549b68 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 6901f62 
>   ambari-server/src/test/python/stacks/2.2/SLIDER/test_slider_client.py 3af55f6 
> 
> Diff: https://reviews.apache.org/r/39486/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 39486: Ambari to install/manage Slider tarball to HDFS

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39486/
-----------------------------------------------------------

(Updated Oct. 20, 2015, 4:52 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-13383
    https://issues.apache.org/jira/browse/AMBARI-13383


Repository: ambari


Description
-------

The following command needs to be invoked (as user hdfs) after the slider
client is installed -

    
    
    
    slider dependency --upload
    

When called in an HDP cluster it will upload the Slider dependency tarball in
an HDP specific path -

    
    
    
    /hdp/apps/<hdp_version>/slider/slider.tar.gz
    

instead of

    
    
    
    /apps/<slider_version>/slider/slider.tar.gz
    

If Ambari wants to upload the tarball without using the slider command-line,
then the tarball needs to be created by packaging all jar files under
`/usr/hdp/current/slider-client/lib/`, except the `slider-core*.jar` file.


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py badf2fe 
  ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params_linux.py 5d60e21 
  ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/service_check.py 18711d7 
  ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider.py a802c19 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 5fe8157 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 7549b68 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 6901f62 
  ambari-server/src/test/python/stacks/2.2/SLIDER/test_slider_client.py 3af55f6 

Diff: https://reviews.apache.org/r/39486/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk