You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/10/17 00:05:50 UTC
Review Request 63054: Updated test filters to include
value-parameterized tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63054/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-7305
https://issues.apache.org/jira/browse/MESOS-7305
Repository: mesos
Description
-------
Test filters currently check the name of tests and type parameters
if they exist. This adds value-parameterized tests to the set of
strings checked against when applying the default test filters.
Diffs
-----
3rdparty/stout/include/stout/tests/environment.hpp 0b30c18ea9bb41854caac3ee6b025e346d04411f
Diff: https://reviews.apache.org/r/63054/diff/1/
Testing
-------
See later in chain.
https://reviews.apache.org/r/63056/ makes it clear why this change is needed.
Thanks,
Joseph Wu
Re: Review Request 63054: Updated test filters to include
value-parameterized tests.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63054/#review190469
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Oct. 17, 2017, 12:05 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63054/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 12:05 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-7305
> https://issues.apache.org/jira/browse/MESOS-7305
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Test filters currently check the name of tests and type parameters
> if they exist. This adds value-parameterized tests to the set of
> strings checked against when applying the default test filters.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/tests/environment.hpp 0b30c18ea9bb41854caac3ee6b025e346d04411f
>
>
> Diff: https://reviews.apache.org/r/63054/diff/1/
>
>
> Testing
> -------
>
> See later in chain.
>
> https://reviews.apache.org/r/63056/ makes it clear why this change is needed.
>
>
> Thanks,
>
> Joseph Wu
>
>