You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by GitBox <gi...@apache.org> on 2020/08/21 14:33:03 UTC
[GitHub] [karaf] skitt opened a new pull request #1165: Code cleanups
skitt opened a new pull request #1165:
URL: https://github.com/apache/karaf/pull/1165
This is mostly automated cleanup; I can split the patch series up if necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] skitt commented on pull request #1165: Code cleanups
Posted by GitBox <gi...@apache.org>.
skitt commented on pull request #1165:
URL: https://github.com/apache/karaf/pull/1165#issuecomment-686945467
> By the way, I'm doing a test on the cherry pick on `karaf-4.2.x` with JDK8 as it should be compatible. Until Karaf 4.3.0 is not released, I would like to keep 4.2.x as close as possible to 4.3.x (easier to cherry pick).
Yup, there’s nothing requiring JDK > 8 here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre merged pull request #1165: Code cleanups
Posted by GitBox <gi...@apache.org>.
jbonofre merged pull request #1165:
URL: https://github.com/apache/karaf/pull/1165
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre commented on pull request #1165: Code cleanups
Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #1165:
URL: https://github.com/apache/karaf/pull/1165#issuecomment-686919819
By the way, I'm doing a test on the cherry pick on `karaf-4.2.x` with JDK8 as it should be compatible. Until Karaf 4.3.0 is not released, I would like to keep 4.2.x as close as possible to 4.3.x (easier to cherry pick).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre commented on pull request #1165: Code cleanups
Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #1165:
URL: https://github.com/apache/karaf/pull/1165#issuecomment-686590425
@skitt do you mind if I squash the commits in one ? It would be easier to me to backport on `karaf-4.2.x` branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre commented on pull request #1165: Code cleanups
Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #1165:
URL: https://github.com/apache/karaf/pull/1165#issuecomment-686603316
@skitt great, I did the review and tested. It's good for me. I'm merging and cherry pick on `karaf-4.2.x`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] skitt commented on pull request #1165: Code cleanups
Posted by GitBox <gi...@apache.org>.
skitt commented on pull request #1165:
URL: https://github.com/apache/karaf/pull/1165#issuecomment-686601933
> @skitt do you mind if I squash the commits in one ? It would be easier to me to backport on `karaf-4.2.x` branch.
No problem, in fact I’ve gone ahead and squashed them myself (in the PR, not merged).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org