You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/01 08:07:51 UTC
[GitHub] [incubator-superset] john-bodley edited a comment on issue #9065:
[sqla] Fixing ORDER BY logic
john-bodley edited a comment on issue #9065: [sqla] Fixing ORDER BY logic
URL: https://github.com/apache/incubator-superset/pull/9065#issuecomment-581002955
@villebro I think that’s the right direction. A couple of caveats; i) the label is optional and thus we probably need different objects depending on the presence of a label, and ii) we also create column from ad-hoc metrics.
I wonder if memoizing `make_sqla_column_compatible` (in essence making a corpus of unique columns) would be the right approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org