You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2015/10/27 21:44:01 UTC
Review Request 39699: GEODE-192: Removing TransactionFunctionService
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39699/
-----------------------------------------------------------
Review request for geode and Swapnil Bawaskar.
Repository: geode
Description
-------
This internal class was added for a use case that is no longer
supported. It has a bug, in that the client may never have connected to
the server that it supposed to be able to look up and invoke the
function on. Deleting the class rather than trying to fix the bug
because the class is no longer needed.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/EndpointManagerImpl.java 5c03be8cc1fb1d96d1637a05d78a74392aea32ef
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/ServerFunctionExecutor.java ba87bb5ef66b25d8cea3bad02d39c7c4a4491d45
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/TransactionFunctionService.java e56e6477b0904d70e6cb5a0c019f40e9f6ad65a0
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/util/CommitFunction.java bafafa99e557110541da16df2a07475c7f0a2a4d
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/util/RollbackFunction.java 7dbfc62b9cf7758749a76ccef7033c19acf8cb8b
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/ClientServerTransactionDUnitTest.java b3611105e5d8369e435098589ba340d9eda538db
Diff: https://reviews.apache.org/r/39699/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 39699: GEODE-192: Removing
TransactionFunctionService
Posted by Swapnil Bawaskar <sb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39699/#review104222
-----------------------------------------------------------
Ship it!
Ship It!
- Swapnil Bawaskar
On Oct. 27, 2015, 8:44 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39699/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 8:44 p.m.)
>
>
> Review request for geode and Swapnil Bawaskar.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This internal class was added for a use case that is no longer
> supported. It has a bug, in that the client may never have connected to
> the server that it supposed to be able to look up and invoke the
> function on. Deleting the class rather than trying to fix the bug
> because the class is no longer needed.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/EndpointManagerImpl.java 5c03be8cc1fb1d96d1637a05d78a74392aea32ef
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/ServerFunctionExecutor.java ba87bb5ef66b25d8cea3bad02d39c7c4a4491d45
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/TransactionFunctionService.java e56e6477b0904d70e6cb5a0c019f40e9f6ad65a0
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/util/CommitFunction.java bafafa99e557110541da16df2a07475c7f0a2a4d
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/util/RollbackFunction.java 7dbfc62b9cf7758749a76ccef7033c19acf8cb8b
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/ClientServerTransactionDUnitTest.java b3611105e5d8369e435098589ba340d9eda538db
>
> Diff: https://reviews.apache.org/r/39699/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>