You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2023/01/31 17:52:25 UTC

[GitHub] [spark] cloud-fan commented on a diff in pull request #39824: [SPARK-42259][SQL] ResolveGroupingAnalytics should take care of Python UDAF

cloud-fan commented on code in PR #39824:
URL: https://github.com/apache/spark/pull/39824#discussion_r1092291311


##########
sql/core/src/test/resources/sql-tests/results/udaf/udaf-group-analytics.sql.out:
##########
@@ -15,18 +15,18 @@ SELECT a + b, b, udaf(a - b) FROM testData GROUP BY a + b, b WITH CUBE
 struct<(a + b):int,b:int,udaf((a - b)):int>
 -- !query output

Review Comment:
   The result should be the same with changing `udaf` to `count`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org