You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/06/29 15:01:35 UTC
[GitHub] [zookeeper] kezhuw opened a new pull request, #1900: ZOOKEEPER-4511: Fix flaky test FileTxnSnapLogMetricsTest.testFileTxnSnapLogMetrics
kezhuw opened a new pull request, #1900:
URL: https://github.com/apache/zookeeper/pull/1900
This test writes txns to trigger snapshot and expects some txns remain
in txn log. But snapshot taking is asynchronous, thus all txns could be
written to snapshot. So in restarting, it is possible that no txns to
load after snapshot restored. This will fail assertion.
This commit solves this by:
* Uses `ZKTestCase.waitFor` to wait for snapshot to be taken.
* Logs more txns after snapshot paused(aka. `FileSnap.close`).
In addition, this commit adds assertions for metric `SNAPSHOT_TIME`.
Author: Kezhu Wang <ke...@gmail.com>
Reviewers: Enrico Olivelli <eo...@apache.org>, Mate Szalay-Beko <sy...@apache.org>
Closes #1852 from kezhuw/ZOOKEEPER-4511-FileTxnSnapLogMetricsTest-testFileTxnSnapLogMetrics
(cherry picked from commit b34e1716e8fa430690252288f2e15c38fe65f325)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] kezhuw commented on pull request #1900: ZOOKEEPER-4511: Fix flaky test FileTxnSnapLogMetricsTest.testFileTxnSnapLogMetrics
Posted by GitBox <gi...@apache.org>.
kezhuw commented on PR #1900:
URL: https://github.com/apache/zookeeper/pull/1900#issuecomment-1170094577
@eolivelli @symat Seems that travis is [not enabled](https://github.com/apache/zookeeper/blob/branch-3.6/.travis.yml) for branch 3.6 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] kezhuw commented on pull request #1900: ZOOKEEPER-4511: Fix flaky test FileTxnSnapLogMetricsTest.testFileTxnSnapLogMetrics
Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw commented on PR #1900:
URL: https://github.com/apache/zookeeper/pull/1900#issuecomment-1430662400
3.6 is end of life.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1900: ZOOKEEPER-4511: Fix flaky test FileTxnSnapLogMetricsTest.testFileTxnSnapLogMetrics
Posted by GitBox <gi...@apache.org>.
symat commented on PR #1900:
URL: https://github.com/apache/zookeeper/pull/1900#issuecomment-1180060316
> Seems that travis is [not enabled](https://github.com/apache/zookeeper/blob/branch-3.6/.travis.yml) for branch 3.6 ?
yeah, it looks the case... we should fix this.
although I don't think it would block this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] kezhuw closed pull request #1900: ZOOKEEPER-4511: Fix flaky test FileTxnSnapLogMetricsTest.testFileTxnSnapLogMetrics
Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw closed pull request #1900: ZOOKEEPER-4511: Fix flaky test FileTxnSnapLogMetricsTest.testFileTxnSnapLogMetrics
URL: https://github.com/apache/zookeeper/pull/1900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org