You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Graham Leggett <mi...@sharp.fm> on 2007/08/31 12:54:44 UTC
Re: [PATCH] Eliminate "13" in modules/aaa/mod_authn_dbd.c /
modules/aaa/mod_authnz_ldap.c
On Fri, August 31, 2007 12:41 pm, Martin Kraemer wrote:
> From the 2.2.x STATUS doc:
> * mod_authn_dbd: Export any additional columns queried in the SQL
> select
> into the environment with the name AUTHENTICATE_<COLUMN>. This brings
> mod_authn_dbd behaviour in line with mod_authnz_ldap.
> Trunk: http://svn.apache.org/viewvc?view=rev&revision=466865
> +1: minfrin
> niq: This wants a little tidying. Use of 13 as a magic number (for a
> strlen of something defined elsewhere) is nasty. More
> importantly
> you need to document how it affects the module's directives.
> I'll +1 it when that's done.
> wrowe: ditto's - good concept.
>
> Here's a patch to eliminate the "13", and to improve portability to
> EBCDIC machines by using apr_toupper().
Thanks for this - the fooness really needed to be sorted out before it was
rolled out over the other authn mechanisms.
We have used the exposed extra columns to support autologin to bugzilla,
amongst other things. The next plan is to update the docs to better
explain how these work.
Regards,
Graham
--
AW: [PATCH] Eliminate "13" in modules/aaa/mod_authn_dbd.c / modules/aaa/mod_authnz_ldap.c
Posted by Plüm,
Rüdiger,
VF-Group <ru...@vodafone.com>.
> -----Ursprüngliche Nachricht-----
> Von: Martin Kraemer
> Gesendet: Freitag, 31. August 2007 17:13
> An: dev@httpd.apache.org
> Betreff: Re: [PATCH] Eliminate "13" in
> modules/aaa/mod_authn_dbd.c / modules/aaa/mod_authnz_ldap.c
>
>
> On Fri, Aug 31, 2007 at 05:09:34PM +0200, Martin Kraemer wrote:
> >
> > Should I commit, or do you?
>
> Forgot to mention that I meant: commit to trunk.
> For 2.2.x, I'd prefer you do it.
For 2.2.x it needs to be added to the original backport proposal of course :-).
But given the current comments in the STATUS file for 2.2.x I guess we can get
the three +1's quickly then.
Regards
Rüdiger
Re: [PATCH] Eliminate "13" in modules/aaa/mod_authn_dbd.c / modules/aaa/mod_authnz_ldap.c
Posted by Martin Kraemer <ma...@apache.org>.
On Fri, Aug 31, 2007 at 05:09:34PM +0200, Martin Kraemer wrote:
>
> Should I commit, or do you?
Forgot to mention that I meant: commit to trunk.
For 2.2.x, I'd prefer you do it.
Martin
--
<Ma...@Fujitsu-Siemens.com> | Fujitsu Siemens
http://www.fujitsu-siemens.com/imprint.html | 81730 Munich, Germany
Re: [PATCH] Eliminate "13" in modules/aaa/mod_authn_dbd.c / modules/aaa/mod_authnz_ldap.c
Posted by Martin Kraemer <ma...@apache.org>.
On Fri, Aug 31, 2007 at 12:54:44PM +0200, Graham Leggett wrote:
> > Here's a patch to eliminate the "13", and to improve portability to
> > EBCDIC machines by using apr_toupper().
>
> Thanks for this - the fooness really needed to be sorted out before it was
> rolled out over the other authn mechanisms.
Should I commit, or do you?
> We have used the exposed extra columns to support autologin to bugzilla,
> amongst other things. The next plan is to update the docs to better
> explain how these work.
+1!
Martin
--
<Ma...@Fujitsu-Siemens.com> | Fujitsu Siemens
http://www.fujitsu-siemens.com/imprint.html | 81730 Munich, Germany