[GitHub] [james-project] quantranhong1999 commented on a change in pull request #504: JAMES-3516 Add threadId column to cassandra tables

[GitBox <gi...@apache.org>]

quantranhong1999 commented on a change in pull request #504:
URL: https://github.com/apache/james-project/pull/504#discussion_r656273593



##########
File path: mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/table/MessageIdToImapUid.java
##########
@@ -29,6 +29,8 @@
 
     String MOD_SEQ = "modSeq";
 
-    String[] FIELDS = { MESSAGE_ID, MAILBOX_ID, IMAP_UID, MOD_SEQ,
+    String THREAD_ID = "threadId";

Review comment:
       We already defined threadId in AppendResult(separately from ComposedMessageId) and MessageMetaData class. IMO it's not suitable if we put threadId into ComposedMessageId or CassandraMessageIds constrants also.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org