You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/11/19 12:27:13 UTC
[GitHub] [kafka] peterwanner opened a new pull request #11517: KAFKA-13466:when kafka-console-producer.sh, batch.size defaults is In…
peterwanner opened a new pull request #11517:
URL: https://github.com/apache/kafka/pull/11517
…consistent with official docs# Please enter the commit message for your changes. Lines starting
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11517: KAFKA-13466:when kafka-console-producer.sh, delete unused config batch.size
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11517:
URL: https://github.com/apache/kafka/pull/11517#issuecomment-1060238911
OK, let's wait for the KIP discussion/vote passed, otherwise, we might need to revert this change. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11517: KAFKA-13466:when kafka-console-producer.sh, delete unused config batch.size
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11517:
URL: https://github.com/apache/kafka/pull/11517#issuecomment-1057947020
retrigger the jenkins build again.
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11517/5/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] peterwanner commented on pull request #11517: KAFKA-13466:when kafka-console-producer.sh, batch.size defaults is In…
Posted by GitBox <gi...@apache.org>.
peterwanner commented on pull request #11517:
URL: https://github.com/apache/kafka/pull/11517#issuecomment-976189946
>
@showuon ok ,and what shoud the lowest version like 2,x which the batch.size is not removed but still have the same error(default error)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11517: KAFKA-13466:when kafka-console-producer.sh, delete unused config batch.size
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11517:
URL: https://github.com/apache/kafka/pull/11517#issuecomment-1057717017
@peterwanner , thanks for the update. I'll merge the PR after the jenkins build completed (and without breaking any tests). Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11517: KAFKA-13466:when kafka-console-producer.sh, delete unused config batch.size
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11517:
URL: https://github.com/apache/kafka/pull/11517#issuecomment-986395925
@dajac , could you help review this PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11517: KAFKA-13466:when kafka-console-producer.sh, batch.size defaults is In…
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11517:
URL: https://github.com/apache/kafka/pull/11517#issuecomment-976196050
> what shoud the lowest version like 2,x which the batch.size is not removed but still have the same error(default error)
Sorry, I don't get your question. What is the error? What is default error? I thought the PR is to fix the "batch.size" default value inconsistency issue. I didn't see any error here.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11517: KAFKA-13466:when kafka-console-producer.sh, delete unused config batch.size
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11517:
URL: https://github.com/apache/kafka/pull/11517#issuecomment-1047537721
@peterwanner , could you please fix the conflicts, so that I can merge the PR? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] peterwanner commented on pull request #11517: KAFKA-13466:when kafka-console-producer.sh, delete unused config batch.size
Posted by GitBox <gi...@apache.org>.
peterwanner commented on pull request #11517:
URL: https://github.com/apache/kafka/pull/11517#issuecomment-1060228152
@showuon ok, i have submited another pr 11855. please have a look at, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #11517: KAFKA-13466:when kafka-console-producer.sh, delete unused config batch.size
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #11517:
URL: https://github.com/apache/kafka/pull/11517#issuecomment-1060021521
Looks like there was a KIP for this too https://cwiki.apache.org/confluence/display/KAFKA/KIP-717%3A+Deprecate+batch-size+config+from+console+producer. We probably should vote it and update the status correctly. cc @kamalcph
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] peterwanner commented on pull request #11517: KAFKA-13466:when kafka-console-producer.sh, delete unused config batch.size
Posted by GitBox <gi...@apache.org>.
peterwanner commented on pull request #11517:
URL: https://github.com/apache/kafka/pull/11517#issuecomment-986387790
> LGTM! Thanks for the patch. @peterwanner , could you please also update the PR title/description, and also the content in KAFKA-13466 in JIRA? Thank you.
@showuon Could you help merge ths PR? Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] peterwanner commented on pull request #11517: KAFKA-13466:when kafka-console-producer.sh, delete unused config batch.size
Posted by GitBox <gi...@apache.org>.
peterwanner commented on pull request #11517:
URL: https://github.com/apache/kafka/pull/11517#issuecomment-976305262
>
ok, jira content and commit title both have changed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #11517: KAFKA-13466:when kafka-console-producer.sh, delete unused config batch.size
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #11517:
URL: https://github.com/apache/kafka/pull/11517#issuecomment-1059795743
We should add a release note since this can cause some applications to break (it's now an error to pass this config vs a no op).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] peterwanner commented on pull request #11517: KAFKA-13466:when kafka-console-producer.sh, batch.size defaults is In…
Posted by GitBox <gi...@apache.org>.
peterwanner commented on pull request #11517:
URL: https://github.com/apache/kafka/pull/11517#issuecomment-976224503
> > what shoud the lowest version like 2,x which the batch.size is not removed but still have the same error(default error)
>
> Sorry, I don't get your question. What is the error? What is default error? I thought the PR is to fix the "batch.size" default value inconsistency issue. I didn't see any error here.
>
> Thanks.
> > what shoud the lowest version like 2,x which the batch.size is not removed but still have the same error(default error)
>
> Sorry, I don't get your question. What is the error? What is default error? I thought the PR is to fix the "batch.size" default value inconsistency issue. I didn't see any error here.
>
> Thanks.
ok I got it , please review. Thanks so much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11517: KAFKA-13466:when kafka-console-producer.sh, delete unused config batch.size
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11517:
URL: https://github.com/apache/kafka/pull/11517#issuecomment-1059851335
@ijuma , good call! Thanks for the reminder.
@peterwanner , could you submit another PR to add a note for v3.2.0 notable change section in `doc/upgrade.html`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon merged pull request #11517: KAFKA-13466:when kafka-console-producer.sh, delete unused config batch.size
Posted by GitBox <gi...@apache.org>.
showuon merged pull request #11517:
URL: https://github.com/apache/kafka/pull/11517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] peterwanner commented on pull request #11517: KAFKA-13466:when kafka-console-producer.sh, delete unused config batch.size
Posted by GitBox <gi...@apache.org>.
peterwanner commented on pull request #11517:
URL: https://github.com/apache/kafka/pull/11517#issuecomment-1057713800
@showuon yes, I have resolve the conflicts, please merge the PR. Thanks a lot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11517: KAFKA-13466:when kafka-console-producer.sh, delete unused config batch.size
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11517:
URL: https://github.com/apache/kafka/pull/11517#issuecomment-1058743569
Failed tests are unrelated and also failed in `trunk` branch.
```
Build / ARM / org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing
Build / JDK 8 and Scala 2.12 / org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing
Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.integration.RebalanceSourceConnectorsIntegrationTest.testDeleteConnector
Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.integration.RebalanceSourceConnectorsIntegrationTest.testDeleteConnector
Build / JDK 11 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()
Build / JDK 11 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()
Build / JDK 11 and Scala 2.13 / org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing
Build / JDK 17 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()
Build / JDK 17 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()
Build / JDK 17 and Scala 2.13 / org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing
Build / JDK 8 and Scala 2.12 / kafka.api.ConsumerBounceTest.testClose()
Build / JDK 11 and Scala 2.13 / kafka.api.ConsumerBounceTest.testClose()
Build / JDK 11 and Scala 2.13 / kafka.api.ConsumerBounceTest.testClose()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11517: KAFKA-13466:when kafka-console-producer.sh, delete unused config batch.size
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11517:
URL: https://github.com/apache/kafka/pull/11517#issuecomment-1058744568
Thanks for the contribution, @peterwanner !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org