[GitHub] [tinkerpop] divijvaidya commented on issue #1109: TINKERPOP-2211 Add API which allows per-request option for bytecode

[GitBox <gi...@apache.org>]

divijvaidya commented on issue #1109: TINKERPOP-2211 Add API which allows per-request option for bytecode
URL: https://github.com/apache/tinkerpop/pull/1109#issuecomment-490311107
 
 
   I completely agree with your suggestion to include query params using the `with()` step but let us take it as part of a separate PR.
   
   This change is primarily for completeness sake given that there might be users who want to use the client as follows:
   
   ```
   final Cluster cluster = createGremlinCluster();
   final Client client = cluster.connect().alias("g");
   final int queryTimeoutMillis = 200;
   final RequestOptions reqOpts = RequestOptions.build().timeout(queryTimeoutMillis).create();
   final ResultSet rsFuture = client.submit(EmptyGraph.instance().traversal().V().count().asAdmin().getBytecode(), reqOpts);
   // Do some application layer work here while server computes the results
   ...
   ...
   // Fetch the results from the server
   rsFuture.all().get(60, TimeUnit.SECONDS);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services