You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ms...@apache.org on 2025/08/22 10:10:17 UTC
(superset) branch master updated: fix(DetailsPanel): Applied filters colors (#34790)
This is an automated email from the ASF dual-hosted git repository.
msyavuz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 2b2cc96f11 fix(DetailsPanel): Applied filters colors (#34790)
2b2cc96f11 is described below
commit 2b2cc96f11dbd14dc7cdbf049824b849810fe560
Author: Mehmet Salih Yavuz <sa...@proton.me>
AuthorDate: Fri Aug 22 13:10:10 2025 +0300
fix(DetailsPanel): Applied filters colors (#34790)
---
.../components/FiltersBadge/DetailsPanel/index.tsx | 23 +++++++++++++---------
.../dashboard/components/FiltersBadge/Styles.tsx | 3 ++-
2 files changed, 16 insertions(+), 10 deletions(-)
diff --git a/superset-frontend/src/dashboard/components/FiltersBadge/DetailsPanel/index.tsx b/superset-frontend/src/dashboard/components/FiltersBadge/DetailsPanel/index.tsx
index 40b4da99c9..18081ca2cb 100644
--- a/superset-frontend/src/dashboard/components/FiltersBadge/DetailsPanel/index.tsx
+++ b/superset-frontend/src/dashboard/components/FiltersBadge/DetailsPanel/index.tsx
@@ -20,7 +20,7 @@ import { RefObject, useEffect, useRef, KeyboardEvent } from 'react';
import { useSelector } from 'react-redux';
import { t, useTheme } from '@superset-ui/core';
-import { Popover } from '@superset-ui/core/components';
+import { List, Popover } from '@superset-ui/core/components';
import {
FiltersContainer,
FiltersDetailsContainer,
@@ -158,14 +158,19 @@ const DetailsPanelPopover = ({
{t('Applied filters (%d)', appliedIndicators.length)}
</SectionName>
<FiltersContainer>
- {appliedIndicators.map(indicator => (
- <FilterIndicator
- ref={el => indicatorRefs.current.push(el)}
- key={indicatorKey(indicator)}
- indicator={indicator}
- onClick={onHighlightFilterSource}
- />
- ))}
+ <List
+ dataSource={appliedIndicators}
+ renderItem={indicator => (
+ <List.Item>
+ <FilterIndicator
+ ref={el => indicatorRefs.current.push(el)}
+ key={indicatorKey(indicator)}
+ indicator={indicator}
+ onClick={onHighlightFilterSource}
+ />
+ </List.Item>
+ )}
+ />
</FiltersContainer>
</div>
) : null}
diff --git a/superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx b/superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
index b58b5d27d8..9c67f1f7f8 100644
--- a/superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
+++ b/superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
@@ -103,6 +103,7 @@ export const FilterItem = styled.button`
export const FiltersContainer = styled.div`
${({ theme }) => css`
+ max-height: 60vh;
margin-top: ${theme.sizeUnit}px;
&:not(:last-child) {
padding-bottom: ${theme.sizeUnit * 3}px;
@@ -116,7 +117,7 @@ export const FiltersDetailsContainer = styled.div`
max-width: 300px;
overflow-x: hidden;
- color: ${theme.colorBgBase};
+ color: ${theme.colorText};
`}
`;