You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lu...@apache.org on 2012/11/16 04:47:08 UTC
svn commit: r1410192 -
/myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js
Author: lu4242
Date: Fri Nov 16 03:47:08 2012
New Revision: 1410192
URL: http://svn.apache.org/viewvc?rev=1410192&view=rev
Log:
small fix add parentesis to allow compressor to work.
Modified:
myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js
Modified: myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js?rev=1410192&r1=1410191&r2=1410192&view=diff
==============================================================================
--- myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js (original)
+++ myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js Fri Nov 16 03:47:08 2012
@@ -372,7 +372,7 @@ _MF_SINGLTN(_PFX_XHR + "_AjaxResponse",
* @param node the changes node to be processed
*/
processUpdate:function (request, context, node) {
- if (node.getAttribute('id').indexOf(this.P_VIEWSTATE) != -1 ||Â node.getAttribute('id').indexOf(this.P_CLIENTWINDOW) != -1) {
+ if ( (node.getAttribute('id').indexOf(this.P_VIEWSTATE) != -1) ||Â (node.getAttribute('id').indexOf(this.P_CLIENTWINDOW) != -1) ) {
//update the submitting forms viewstate to the new value
// The source form has to be pulled out of the CURRENT document first because the context object
// may refer to an invalid document if an update of the entire body has occurred before this point.
Re: svn commit: r1410192 - /myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js
Posted by Mark Struberg <st...@yahoo.de>.
Hmm, not sure - I was not even able to compile the project because of that.
In any case please watch this issue. Maybe there is a file encoding issue on some box, email, etc.
LieGrue,
strub
----- Original Message -----
> From: Leonardo Uribe <lu...@gmail.com>
> To: MyFaces Development <de...@myfaces.apache.org>; Mark Struberg <st...@yahoo.de>
> Cc:
> Sent: Friday, November 16, 2012 4:03 PM
> Subject: Re: svn commit: r1410192 - /myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js
>
> 2012/11/16 Mark Struberg <st...@yahoo.de>:
>> there seems to be a UTF character in the JavaScript you committed
> ('Â'). This might be broken on a few browsers.
>> Or is this only a commit mail artifact? (which I don't believe)
>>
>>
>
> Ok, thanks for fix it. I have seen this issue in the past, it happens
> when Werner edits the code and by some reason, that invisible
> character is added (it does not happen in my machine). The solution is
> just remove it.
>
>>
>>
>>
>> ----- Original Message -----
>>> From: "lu4242@apache.org" <lu...@apache.org>
>>> To: commits@myfaces.apache.org
>>> Cc:
>>> Sent: Friday, November 16, 2012 4:47 AM
>>> Subject: svn commit: r1410192 -
> /myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js
>>>
>>> Author: lu4242
>>> Date: Fri Nov 16 03:47:08 2012
>>> New Revision: 1410192
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1410192&view=rev
>>> Log:
>>> small fix add parentesis to allow compressor to work.
>>>
>>> Modified:
>>>
>>>
> myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js
>>>
>>> Modified:
>>>
> myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js
>>> URL:
>>>
> http://svn.apache.org/viewvc/myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js?rev=1410192&r1=1410191&r2=1410192&view=diff
>>>
> ==============================================================================
>>> ---
>>>
> myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js
>>> (original)
>>> +++
>>>
> myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js
>>> Fri Nov 16 03:47:08 2012
>>> @@ -372,7 +372,7 @@ _MF_SINGLTN(_PFX_XHR + "_AjaxResponse",
>>> * @param node the changes node to be processed
>>> */
>>> processUpdate:function (request, context, node) {
>>> - if (node.getAttribute('id').indexOf(this.P_VIEWSTATE)
> != -1
>>> ||Â node.getAttribute('id').indexOf(this.P_CLIENTWINDOW) != -1)
> {
>>> + if (
> (node.getAttribute('id').indexOf(this.P_VIEWSTATE) != -1)
>>> ||Â (node.getAttribute('id').indexOf(this.P_CLIENTWINDOW) !=
> -1) ) {
>>> //update the submitting forms viewstate to the new value
>>> // The source form has to be pulled out of the CURRENT
> document
>>> first because the context object
>>> // may refer to an invalid document if an update of the
> entire body
>>> has occurred before this point.
>>>
>
Re: svn commit: r1410192 - /myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js
Posted by Leonardo Uribe <lu...@gmail.com>.
2012/11/16 Mark Struberg <st...@yahoo.de>:
> there seems to be a UTF character in the JavaScript you committed ('Â'). This might be broken on a few browsers.
> Or is this only a commit mail artifact? (which I don't believe)
>
>
Ok, thanks for fix it. I have seen this issue in the past, it happens
when Werner edits the code and by some reason, that invisible
character is added (it does not happen in my machine). The solution is
just remove it.
>
>
>
> ----- Original Message -----
>> From: "lu4242@apache.org" <lu...@apache.org>
>> To: commits@myfaces.apache.org
>> Cc:
>> Sent: Friday, November 16, 2012 4:47 AM
>> Subject: svn commit: r1410192 - /myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js
>>
>> Author: lu4242
>> Date: Fri Nov 16 03:47:08 2012
>> New Revision: 1410192
>>
>> URL: http://svn.apache.org/viewvc?rev=1410192&view=rev
>> Log:
>> small fix add parentesis to allow compressor to work.
>>
>> Modified:
>>
>> myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js
>>
>> Modified:
>> myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js
>> URL:
>> http://svn.apache.org/viewvc/myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js?rev=1410192&r1=1410191&r2=1410192&view=diff
>> ==============================================================================
>> ---
>> myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js
>> (original)
>> +++
>> myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js
>> Fri Nov 16 03:47:08 2012
>> @@ -372,7 +372,7 @@ _MF_SINGLTN(_PFX_XHR + "_AjaxResponse",
>> * @param node the changes node to be processed
>> */
>> processUpdate:function (request, context, node) {
>> - if (node.getAttribute('id').indexOf(this.P_VIEWSTATE) != -1
>> ||Â node.getAttribute('id').indexOf(this.P_CLIENTWINDOW) != -1) {
>> + if ( (node.getAttribute('id').indexOf(this.P_VIEWSTATE) != -1)
>> ||Â (node.getAttribute('id').indexOf(this.P_CLIENTWINDOW) != -1) ) {
>> //update the submitting forms viewstate to the new value
>> // The source form has to be pulled out of the CURRENT document
>> first because the context object
>> // may refer to an invalid document if an update of the entire body
>> has occurred before this point.
>>
Re: svn commit: r1410192 - /myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js
Posted by Mark Struberg <st...@yahoo.de>.
there seems to be a UTF character in the JavaScript you committed ('Â'). This might be broken on a few browsers.
Or is this only a commit mail artifact? (which I don't believe)
----- Original Message -----
> From: "lu4242@apache.org" <lu...@apache.org>
> To: commits@myfaces.apache.org
> Cc:
> Sent: Friday, November 16, 2012 4:47 AM
> Subject: svn commit: r1410192 - /myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js
>
> Author: lu4242
> Date: Fri Nov 16 03:47:08 2012
> New Revision: 1410192
>
> URL: http://svn.apache.org/viewvc?rev=1410192&view=rev
> Log:
> small fix add parentesis to allow compressor to work.
>
> Modified:
>
> myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js
>
> Modified:
> myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js
> URL:
> http://svn.apache.org/viewvc/myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js?rev=1410192&r1=1410191&r2=1410192&view=diff
> ==============================================================================
> ---
> myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js
> (original)
> +++
> myfaces/core/branches/2.2.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js
> Fri Nov 16 03:47:08 2012
> @@ -372,7 +372,7 @@ _MF_SINGLTN(_PFX_XHR + "_AjaxResponse",
> * @param node the changes node to be processed
> */
> processUpdate:function (request, context, node) {
> - if (node.getAttribute('id').indexOf(this.P_VIEWSTATE) != -1
> ||Â node.getAttribute('id').indexOf(this.P_CLIENTWINDOW) != -1) {
> + if ( (node.getAttribute('id').indexOf(this.P_VIEWSTATE) != -1)
> ||Â (node.getAttribute('id').indexOf(this.P_CLIENTWINDOW) != -1) ) {
> //update the submitting forms viewstate to the new value
> // The source form has to be pulled out of the CURRENT document
> first because the context object
> // may refer to an invalid document if an update of the entire body
> has occurred before this point.
>