You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by de...@apache.org on 2018/09/21 11:15:30 UTC

[incubator-echarts] branch master updated: refactor(themeRiver): refactor the series of themeRiver

This is an automated email from the ASF dual-hosted git repository.

deqingli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git


The following commit(s) were added to refs/heads/master by this push:
     new d7e42c6  refactor(themeRiver): refactor the series of themeRiver
     new dc95d85  Merge branch 'master' of https://github.com/apache/incubator-echarts
d7e42c6 is described below

commit d7e42c69f6f7ef07f12141afbe82da1ae24d3b49
Author: deqingli <an...@gmail.com>
AuthorDate: Fri Sep 21 19:13:29 2018 +0800

    refactor(themeRiver): refactor the series of themeRiver
---
 src/chart/themeRiver/ThemeRiverSeries.js | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/chart/themeRiver/ThemeRiverSeries.js b/src/chart/themeRiver/ThemeRiverSeries.js
index 3e7915a..6d00345 100644
--- a/src/chart/themeRiver/ThemeRiverSeries.js
+++ b/src/chart/themeRiver/ThemeRiverSeries.js
@@ -218,11 +218,9 @@ var ThemeRiverSeries = SeriesModel.extend({
         var timeDim = data.mapDimension('single');
 
         for (var j = 0; j < layerSeries.length; ++j) {
-            layerSeries[j].indices.sort(comparer);
-        }
-
-        function comparer(index1, index2) {
-            return data.get(timeDim, index1) - data.get(timeDim, index2);
+            layerSeries[j].indices.sort(function (index1, index2) {
+                return data.get(timeDim, index1) - data.get(timeDim, index2);
+            });
         }
 
         return layerSeries;


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org