[GitHub] [kyuubi] bowenliang123 commented on pull request #5217: [KYUUBI #5216] Limit counter resource leak in SessionLimiter.

["bowenliang123 (via GitHub)" <gi...@apache.org>]

bowenliang123 commented on PR #5217:
URL: https://github.com/apache/kyuubi/pull/5217#issuecomment-1698851856

   > I think we can use a new limiter when updating the config instead of just updating the old limiter's configurations. Updating the limiter configuration is a very rare operation, so we can completely discard the previous state and use a new limiter. WDYT? cc @pan3793 @bowenliang123
   
   SGTM. Two main points are again on ‘Compare and Swap’ and thread-safe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org