You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by GitBox <gi...@apache.org> on 2020/07/18 19:18:18 UTC

[GitHub] [incubator-streampipes] amkcpu opened a new pull request #22: Add list of event keys to allow for Siddhi PEs with multiple streams

amkcpu opened a new pull request #22:
URL: https://github.com/apache/incubator-streampipes/pull/22


   ### Purpose
   Currently, there is only one list of event keys (attributes), which gets expanded with the keys from all streams: `sortedEventKeys`.
   When connecting multiple streams to a Siddhi processing element, this leads to `NullPointerException`s and duplicate keys in the stream definition clause.
   This PR adds a HashMap containing a separate list of event keys for each stream.
   
   ### Approach
   1. Adds the `listOfEventKeys` HashMap. Keys are the stream names, values are the lists containing the respective event key. This is somewhat similar to the already existing `siddhiInputHandlers` Map, just with a different purpose.
   2. Changes registerEventTypeIfNotExists() to put new event keys there when invocating the processing element.
   3. Changes onEvent() and toObjArr() to use the HashMap when receiving new events.
   
   ### Remarks
   Jira issue: None
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampipes] wipatrick commented on pull request #22: Add list of event keys to allow for Siddhi PEs with multiple streams

Posted by GitBox <gi...@apache.org>.
wipatrick commented on pull request #22:
URL: https://github.com/apache/incubator-streampipes/pull/22#issuecomment-660973044


   I tested this PR and it works as described. Thanks for the contribution @amkcpu 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampipes] wipatrick merged pull request #22: Add list of event keys to allow for Siddhi PEs with multiple streams

Posted by GitBox <gi...@apache.org>.
wipatrick merged pull request #22:
URL: https://github.com/apache/incubator-streampipes/pull/22


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org