You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "chiranmoyf (via GitHub)" <gi...@apache.org> on 2025/11/07 07:02:53 UTC
[PR] [CH] Improve SparkFloorFunction performance with SVE [incubator-gluten]
chiranmoyf opened a new pull request, #11045:
URL: https://github.com/apache/incubator-gluten/pull/11045
<!--
Thank you for submitting a pull request! Here are some tips:
1. For first-time contributors, please read our contributing guide:
https://github.com/apache/incubator-gluten/blob/main/CONTRIBUTING.md
2. If necessary, create a GitHub issue for discussion beforehand to avoid duplicate work.
3. If the PR is specific to a single backend, include [VL] or [CH] in the PR title to indicate the
Velox or ClickHouse backend, respectively.
4. If the PR is not ready for review, please mark it as a draft.
-->
## What changes are proposed in this pull request?
This commit introduces support for the Scalable Vector Extension (SVE) in SparkFloorFunction.
## How was this patch tested?
We've used Google's microbenchmark `BM_SparkFloorFunction_For_Float64` to test the patch. The results are presented below.
```
./build_gcc/utils/extern-local-engine/tests/benchmark_local_engine --benchmark_filter="BM.*SparkFloor.*Float64"
# Before optimization (Scalar)
----------------------------------------------------------------------------
Benchmark Time CPU Iterations
----------------------------------------------------------------------------
BM_SparkFloorFunction_For_Float64 79407 ns 79407 ns 8768
# After optimization (SVE)
----------------------------------------------------------------------------
Benchmark Time CPU Iterations
----------------------------------------------------------------------------
BM_SparkFloorFunction_For_Float64 40479 ns 40479 ns 17291
```
We are getting around 2x performance improvement on AWS Graviton3 (m7g.4xlarge).
## Note
SVE detection and macros used here are enabled in Clickhouse. We are raising this PR as draft since the Clickhouse PR is under review. Here in the Clickhouse PR for reference - https://github.com/ClickHouse/ClickHouse/pull/85010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CH] Improve SparkFloorFunction performance with SVE [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11045:
URL: https://github.com/apache/incubator-gluten/pull/11045#issuecomment-3976118421
This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CH] Improve SparkFloorFunction performance with SVE [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #11045: [CH] Improve SparkFloorFunction performance with SVE
URL: https://github.com/apache/incubator-gluten/pull/11045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CH] Improve SparkFloorFunction performance with SVE [incubator-gluten]
Posted by "taiyang-li (via GitHub)" <gi...@apache.org>.
taiyang-li commented on PR #11045:
URL: https://github.com/apache/incubator-gluten/pull/11045#issuecomment-3506345841
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CH] Improve SparkFloorFunction performance with SVE [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11045:
URL: https://github.com/apache/incubator-gluten/pull/11045#issuecomment-3911592340
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CH] Improve SparkFloorFunction performance with SVE [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11045:
URL: https://github.com/apache/incubator-gluten/pull/11045#issuecomment-3688416883
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CH] Improve SparkFloorFunction performance with SVE [incubator-gluten]
Posted by "chiranmoyf (via GitHub)" <gi...@apache.org>.
chiranmoyf commented on PR #11045:
URL: https://github.com/apache/incubator-gluten/pull/11045#issuecomment-3704978506
The build error occurs because the macros are undefined in ClickHouse. We are working on the ClickHouse PR. Once it is merged, the issue should be resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CH] Improve SparkFloorFunction performance with SVE [incubator-gluten]
Posted by "taiyang-li (via GitHub)" <gi...@apache.org>.
taiyang-li commented on PR #11045:
URL: https://github.com/apache/incubator-gluten/pull/11045#issuecomment-3506348998
<img width="2954" height="894" alt="image" src="https://github.com/user-attachments/assets/d3ab77c5-cda7-4e33-99c6-9da657939bc3" />
It seems related to the changes. cc @chiranmoyf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CH] Improve SparkFloorFunction performance with SVE [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11045:
URL: https://github.com/apache/incubator-gluten/pull/11045#issuecomment-3501031222
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org