svn commit: r1072631 - in /mahout/trunk: core/src/main/java/org/apache/mahout/cf/taste/impl/common/ core/src/main/java/org/apache/mahout/cf/taste/impl/model/jdbc/ core/src/main/java/org/apache/mahout/common/ math/src/main/java/org/apache/mahout/math/als/

[ss...@apache.org]

Author: ssc
Date: Sun Feb 20 16:52:09 2011
New Revision: 1072631

URL: http://svn.apache.org/viewvc?rev=1072631&view=rev
Log:
MAHOUT-613 Added descriptive messages to calls to Preconditions.checkNotNull()

Modified:
    mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/common/RefreshRunnable.java
    mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/model/jdbc/ReloadFromJDBCDataModel.java
    mahout/trunk/core/src/main/java/org/apache/mahout/common/IOUtils.java
    mahout/trunk/math/src/main/java/org/apache/mahout/math/als/AlternateLeastSquaresSolver.java

Modified: mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/common/RefreshRunnable.java
URL: http://svn.apache.org/viewvc/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/common/RefreshRunnable.java?rev=1072631&r1=1072630&r2=1072631&view=diff
==============================================================================
--- mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/common/RefreshRunnable.java (original)
+++ mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/common/RefreshRunnable.java Sun Feb 20 16:52:09 2011
@@ -24,13 +24,15 @@ import java.util.concurrent.Callable;
 
 /**
  * Simply calls {@linkRefreshable#refresh(java.util.Collection)} on a {@link Refreshable}.
+ *
+ * @deprecated Not used by RefreshHelper anymore.
  */
 public final class RefreshRunnable implements Runnable, Callable<Void> {
 
   private final Refreshable refreshable;
 
   public RefreshRunnable(Refreshable refreshable) {
-    Preconditions.checkNotNull(refreshable);
+    Preconditions.checkNotNull(refreshable, "Refreshable cannot be null");
     this.refreshable = refreshable;
   }
 

Modified: mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/model/jdbc/ReloadFromJDBCDataModel.java
URL: http://svn.apache.org/viewvc/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/model/jdbc/ReloadFromJDBCDataModel.java?rev=1072631&r1=1072630&r2=1072631&view=diff
==============================================================================
--- mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/model/jdbc/ReloadFromJDBCDataModel.java (original)
+++ mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/model/jdbc/ReloadFromJDBCDataModel.java Sun Feb 20 16:52:09 2011
@@ -48,7 +48,7 @@ public final class ReloadFromJDBCDataMod
   private final RefreshHelper refreshHelper;
 
   public ReloadFromJDBCDataModel(JDBCDataModel delegate) throws TasteException {
-    Preconditions.checkNotNull(delegate);
+    Preconditions.checkNotNull(delegate, "Delegate cannot be null");
     this.delegate = delegate;
     refreshHelper = new RefreshHelper(new Callable<Void>() {
       @Override

Modified: mahout/trunk/core/src/main/java/org/apache/mahout/common/IOUtils.java
URL: http://svn.apache.org/viewvc/mahout/trunk/core/src/main/java/org/apache/mahout/common/IOUtils.java?rev=1072631&r1=1072630&r2=1072631&view=diff
==============================================================================
--- mahout/trunk/core/src/main/java/org/apache/mahout/common/IOUtils.java (original)
+++ mahout/trunk/core/src/main/java/org/apache/mahout/common/IOUtils.java Sun Feb 20 16:52:09 2011
@@ -40,7 +40,7 @@ public final class IOUtils {
   private IOUtils() { }
   
   public static void quietClose(Closeable... closeables) {
-    Preconditions.checkNotNull(closeables);
+    Preconditions.checkNotNull(closeables, "Closables cannot be null");
     for (Closeable closeable : closeables) {
       if (closeable != null) {
         try {

Modified: mahout/trunk/math/src/main/java/org/apache/mahout/math/als/AlternateLeastSquaresSolver.java
URL: http://svn.apache.org/viewvc/mahout/trunk/math/src/main/java/org/apache/mahout/math/als/AlternateLeastSquaresSolver.java?rev=1072631&r1=1072630&r2=1072631&view=diff
==============================================================================
--- mahout/trunk/math/src/main/java/org/apache/mahout/math/als/AlternateLeastSquaresSolver.java (original)
+++ mahout/trunk/math/src/main/java/org/apache/mahout/math/als/AlternateLeastSquaresSolver.java Sun Feb 20 16:52:09 2011
@@ -33,9 +33,9 @@ public class AlternateLeastSquaresSolver
 
   public Vector solve(List<Vector> featureVectors, Vector ratingVector, double lambda, int numFeatures) {
 
-    Preconditions.checkNotNull(featureVectors);
+    Preconditions.checkNotNull(featureVectors, "Feature vectors cannot be null");
     Preconditions.checkArgument(!featureVectors.isEmpty());
-    Preconditions.checkNotNull(ratingVector);    
+    Preconditions.checkNotNull(ratingVector, "Rating vector cannot be null");
     Preconditions.checkArgument(featureVectors.size() == ratingVector.getNumNondefaultElements());
 
     int nui = ratingVector.getNumNondefaultElements();