You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/10/11 08:18:16 UTC

[GitHub] [apisix-dashboard] yangxikun opened a new issue #2166: Route.vars support "!" operator

yangxikun opened a new issue #2166:
URL: https://github.com/apache/apisix-dashboard/issues/2166


   https://github.com/api7/lua-resty-expr#operator-list
   
   I suggest add a checkbox to support the "!" operator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] LiteSun commented on issue #2166: route.vars support "!" operator

Posted by GitBox <gi...@apache.org>.
LiteSun commented on issue #2166:
URL: https://github.com/apache/apisix-dashboard/issues/2166#issuecomment-1056065277


   @SkyeYoung hi, would you like to improve this 😊


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] SkyeYoung commented on issue #2166: route.vars support "!" operator

Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on issue #2166:
URL: https://github.com/apache/apisix-dashboard/issues/2166#issuecomment-1055079253


   I browsed through https://github.com/api7/lua-resty-expr/blob/main/t/v1/not.t, looks like the "!" operator is used in combination with other operators.
   
   Maybe a single checkbox is a better choice.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] yangxikun commented on issue #2166: Route.vars support "!" operator

Posted by GitBox <gi...@apache.org>.
yangxikun commented on issue #2166:
URL: https://github.com/apache/apisix-dashboard/issues/2166#issuecomment-948331823


   @bzp2010 @starsz 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] starsz commented on issue #2166: Route.vars support "!" operator

Posted by GitBox <gi...@apache.org>.
starsz commented on issue #2166:
URL: https://github.com/apache/apisix-dashboard/issues/2166#issuecomment-958745895






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] starsz commented on issue #2166: Route.vars support "!" operator

Posted by GitBox <gi...@apache.org>.
starsz commented on issue #2166:
URL: https://github.com/apache/apisix-dashboard/issues/2166#issuecomment-958745895


   cc @LiteSun Please check about it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] zaunist commented on issue #2166: route.vars support "!" operator

Posted by GitBox <gi...@apache.org>.
zaunist commented on issue #2166:
URL: https://github.com/apache/apisix-dashboard/issues/2166#issuecomment-1056123318


   > @LiteSun Yes, I'd like to try.
   
   Great !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] starsz commented on issue #2166: Route.vars support "!" operator

Posted by GitBox <gi...@apache.org>.
starsz commented on issue #2166:
URL: https://github.com/apache/apisix-dashboard/issues/2166#issuecomment-958745895


   cc @LiteSun Please check about it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] bzp2010 closed issue #2166: route.vars support "!" operator

Posted by GitBox <gi...@apache.org>.
bzp2010 closed issue #2166:
URL: https://github.com/apache/apisix-dashboard/issues/2166


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] zaunist commented on issue #2166: Route.vars support "!" operator

Posted by GitBox <gi...@apache.org>.
zaunist commented on issue #2166:
URL: https://github.com/apache/apisix-dashboard/issues/2166#issuecomment-942903396


   > https://github.com/api7/lua-resty-expr#operator-list
   > 
   > I suggest add a checkbox to support the "!" operator.
   
   In what situation do we need to use "!" ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] yangxikun removed a comment on issue #2166: Route.vars support "!" operator

Posted by GitBox <gi...@apache.org>.
yangxikun removed a comment on issue #2166:
URL: https://github.com/apache/apisix-dashboard/issues/2166#issuecomment-948331823


   @bzp2010 @starsz 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] LiteSun commented on issue #2166: route.vars support "!" operator

Posted by GitBox <gi...@apache.org>.
LiteSun commented on issue #2166:
URL: https://github.com/apache/apisix-dashboard/issues/2166#issuecomment-1056073133


   Great! @SkyeYoung  if you have any problems, feel free to comment here. also, cc @guoqqqi  to watch this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] SkyeYoung commented on issue #2166: route.vars support "!" operator

Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on issue #2166:
URL: https://github.com/apache/apisix-dashboard/issues/2166#issuecomment-1056066024


   @LiteSun Yes, I'd like to try.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] starsz commented on issue #2166: Route.vars support "!" operator

Posted by GitBox <gi...@apache.org>.
starsz commented on issue #2166:
URL: https://github.com/apache/apisix-dashboard/issues/2166#issuecomment-946300189


   ![image](https://user-images.githubusercontent.com/25628854/137830535-454310aa-e2d1-46e4-8449-0aefacf427c9.png)
   Do you mean this ?
   APISIX-Dashboard had supported "!" already.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] yangxikun commented on issue #2166: Route.vars support "!" operator

Posted by GitBox <gi...@apache.org>.
yangxikun commented on issue #2166:
URL: https://github.com/apache/apisix-dashboard/issues/2166#issuecomment-948334428


   @bzp2010 @starsz 
   
   I create a route by admin api:
   
   ```
   {
       ...
       "vars": [
           [
             "uri",
             "!",
             "~~",
             "(/v1/|^/assets/|^/world/assets/|^/tracker|^/auth/|^/admin|^/wiki|^/suites|^/cgi-bin|^/open/|^/preview/)"
           ]
       ]
       ....
   }
   ```
   
   then the UI is wrong:
   
   ![image](https://user-images.githubusercontent.com/3364160/138230909-57ad7514-fa14-49e9-aed4-97034bcd189f.png)
   
   "!" should be a checkbox, not in the dropdown list.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org