You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by wh...@apache.org on 2014/11/05 00:19:30 UTC

git commit: HDFS-7355. TestDataNodeVolumeFailure#testUnderReplicationAfterVolFailure fails on Windows, because we cannot deny access to the file owner. Contributed by Chris Nauroth.

Repository: hadoop
Updated Branches:
  refs/heads/branch-2.6 1b54fa6e2 -> 0fde606e3


HDFS-7355. TestDataNodeVolumeFailure#testUnderReplicationAfterVolFailure fails on Windows, because we cannot deny access to the file owner. Contributed by Chris Nauroth.


Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/0fde606e
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/0fde606e
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/0fde606e

Branch: refs/heads/branch-2.6
Commit: 0fde606e3ff04841f84cac32ac51be965e19ea8c
Parents: 1b54fa6
Author: Haohui Mai <wh...@apache.org>
Authored: Tue Nov 4 15:18:51 2014 -0800
Committer: Haohui Mai <wh...@apache.org>
Committed: Tue Nov 4 15:19:18 2014 -0800

----------------------------------------------------------------------
 hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt                     | 4 ++++
 .../hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java  | 5 +++++
 2 files changed, 9 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hadoop/blob/0fde606e/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
----------------------------------------------------------------------
diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
index 1442569..851f9ed 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
+++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
@@ -719,6 +719,10 @@ Release 2.6.0 - UNRELEASED
     HDFS-7334. Fix periodic failures of TestCheckpoint
     #testTooManyEditReplayFailures. (Charles Lamb via wheat9)
 
+    HDFS-7355. TestDataNodeVolumeFailure#testUnderReplicationAfterVolFailure
+    fails on Windows, because we cannot deny access to the file owner.
+    (Chris Nauroth via wheat9)
+
     BREAKDOWN OF HDFS-6134 AND HADOOP-10150 SUBTASKS AND RELATED JIRAS
   
       HDFS-6387. HDFS CLI admin tool for creating & deleting an

http://git-wip-us.apache.org/repos/asf/hadoop/blob/0fde606e/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
----------------------------------------------------------------------
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
index 8429055..6b9c4b1 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
@@ -205,6 +205,11 @@ public class TestDataNodeVolumeFailure {
    */
   @Test
   public void testUnderReplicationAfterVolFailure() throws Exception {
+    // This test relies on denying access to data volumes to simulate data volume
+    // failure.  This doesn't work on Windows, because an owner of an object
+    // always has the ability to read and change permissions on the object.
+    assumeTrue(!Path.WINDOWS);
+
     // Bring up one more datanode
     cluster.startDataNodes(conf, 1, true, null, null);
     cluster.waitActive();