You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/10 13:17:22 UTC
[GitHub] [flink] godfreyhe opened a new pull request #12872: [FLINK-18550][sql-client] use TableResult#collect to get select result for sql client
godfreyhe opened a new pull request #12872:
URL: https://github.com/apache/flink/pull/12872
## What is the purpose of the change
*This pr aims to use TableResult#collect to get select result instead of using user defined sink. which could reduce a lot of code.*
## Brief change log
- *use TableResult#collect to get select result for sql client*
- *remove useless code about Deployment in sql client*
- *use RowKind instead of Tuple2 to represent changes in sql client*
## Verifying this change
This change is already covered by existing tests, such as LocalExecutorITCase, and add some new test to verify the change, such as MaterializedCollectBatchResultTest.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12872: [FLINK-18550][sql-client] use TableResult#collect to get select result for sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12872:
URL: https://github.com/apache/flink/pull/12872#issuecomment-656681765
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5245b1af2c8035c72dda41c271d8e5a251161210",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4407",
"triggerID" : "5245b1af2c8035c72dda41c271d8e5a251161210",
"triggerType" : "PUSH"
}, {
"hash" : "913aaebdeacc913d6b9f8498d55547aa8d480f10",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4525",
"triggerID" : "913aaebdeacc913d6b9f8498d55547aa8d480f10",
"triggerType" : "PUSH"
}, {
"hash" : "71ee80061eebe7ee3dc50b2b73e991cc074d3e26",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "71ee80061eebe7ee3dc50b2b73e991cc074d3e26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 913aaebdeacc913d6b9f8498d55547aa8d480f10 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4525)
* 71ee80061eebe7ee3dc50b2b73e991cc074d3e26 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong closed pull request #12872: [FLINK-18550][sql-client] use TableResult#collect to get select result for sql client
Posted by GitBox <gi...@apache.org>.
wuchong closed pull request #12872:
URL: https://github.com/apache/flink/pull/12872
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12872: [FLINK-18550][sql-client] use TableResult#collect to get select result for sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12872:
URL: https://github.com/apache/flink/pull/12872#issuecomment-656681765
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5245b1af2c8035c72dda41c271d8e5a251161210",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4407",
"triggerID" : "5245b1af2c8035c72dda41c271d8e5a251161210",
"triggerType" : "PUSH"
}, {
"hash" : "913aaebdeacc913d6b9f8498d55547aa8d480f10",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4525",
"triggerID" : "913aaebdeacc913d6b9f8498d55547aa8d480f10",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 913aaebdeacc913d6b9f8498d55547aa8d480f10 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4525)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12872: [FLINK-18550][sql-client] use TableResult#collect to get select result for sql client
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12872:
URL: https://github.com/apache/flink/pull/12872#issuecomment-656673060
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 5245b1af2c8035c72dda41c271d8e5a251161210 (Fri Jul 10 13:19:45 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12872: [FLINK-18550][sql-client] use TableResult#collect to get select result for sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12872:
URL: https://github.com/apache/flink/pull/12872#issuecomment-656681765
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5245b1af2c8035c72dda41c271d8e5a251161210",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4407",
"triggerID" : "5245b1af2c8035c72dda41c271d8e5a251161210",
"triggerType" : "PUSH"
}, {
"hash" : "913aaebdeacc913d6b9f8498d55547aa8d480f10",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4525",
"triggerID" : "913aaebdeacc913d6b9f8498d55547aa8d480f10",
"triggerType" : "PUSH"
}, {
"hash" : "71ee80061eebe7ee3dc50b2b73e991cc074d3e26",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4907",
"triggerID" : "71ee80061eebe7ee3dc50b2b73e991cc074d3e26",
"triggerType" : "PUSH"
}, {
"hash" : "afe8c61ab72eebcd31af3073047cf6d1a93e74ae",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10236",
"triggerID" : "afe8c61ab72eebcd31af3073047cf6d1a93e74ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* afe8c61ab72eebcd31af3073047cf6d1a93e74ae Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10236)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12872: [FLINK-18550][sql-client] use TableResult#collect to get select result for sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12872:
URL: https://github.com/apache/flink/pull/12872#issuecomment-656681765
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5245b1af2c8035c72dda41c271d8e5a251161210",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4407",
"triggerID" : "5245b1af2c8035c72dda41c271d8e5a251161210",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5245b1af2c8035c72dda41c271d8e5a251161210 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4407)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12872: [FLINK-18550][sql-client] use TableResult#collect to get select result for sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12872:
URL: https://github.com/apache/flink/pull/12872#issuecomment-656681765
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5245b1af2c8035c72dda41c271d8e5a251161210",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4407",
"triggerID" : "5245b1af2c8035c72dda41c271d8e5a251161210",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5245b1af2c8035c72dda41c271d8e5a251161210 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4407)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12872: [FLINK-18550][sql-client] use TableResult#collect to get select result for sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12872:
URL: https://github.com/apache/flink/pull/12872#issuecomment-656681765
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5245b1af2c8035c72dda41c271d8e5a251161210",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4407",
"triggerID" : "5245b1af2c8035c72dda41c271d8e5a251161210",
"triggerType" : "PUSH"
}, {
"hash" : "913aaebdeacc913d6b9f8498d55547aa8d480f10",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4525",
"triggerID" : "913aaebdeacc913d6b9f8498d55547aa8d480f10",
"triggerType" : "PUSH"
}, {
"hash" : "71ee80061eebe7ee3dc50b2b73e991cc074d3e26",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4907",
"triggerID" : "71ee80061eebe7ee3dc50b2b73e991cc074d3e26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 71ee80061eebe7ee3dc50b2b73e991cc074d3e26 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4907)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #12872: [FLINK-18550][sql-client] use TableResult#collect to get select result for sql client
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12872:
URL: https://github.com/apache/flink/pull/12872#issuecomment-783867423
continue reviewing in #14958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12872: [FLINK-18550][sql-client] use TableResult#collect to get select result for sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12872:
URL: https://github.com/apache/flink/pull/12872#issuecomment-656681765
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5245b1af2c8035c72dda41c271d8e5a251161210",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4407",
"triggerID" : "5245b1af2c8035c72dda41c271d8e5a251161210",
"triggerType" : "PUSH"
}, {
"hash" : "913aaebdeacc913d6b9f8498d55547aa8d480f10",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4525",
"triggerID" : "913aaebdeacc913d6b9f8498d55547aa8d480f10",
"triggerType" : "PUSH"
}, {
"hash" : "71ee80061eebe7ee3dc50b2b73e991cc074d3e26",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4907",
"triggerID" : "71ee80061eebe7ee3dc50b2b73e991cc074d3e26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 913aaebdeacc913d6b9f8498d55547aa8d480f10 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4525)
* 71ee80061eebe7ee3dc50b2b73e991cc074d3e26 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4907)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #12872: [FLINK-18550][sql-client] use TableResult#collect to get select result for sql client
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #12872:
URL: https://github.com/apache/flink/pull/12872#issuecomment-666344881
cc @JingsongLi
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #12872: [FLINK-18550][sql-client] use TableResult#collect to get select result for sql client
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #12872:
URL: https://github.com/apache/flink/pull/12872#issuecomment-734723938
cc @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12872: [FLINK-18550][sql-client] use TableResult#collect to get select result for sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12872:
URL: https://github.com/apache/flink/pull/12872#issuecomment-656681765
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5245b1af2c8035c72dda41c271d8e5a251161210",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4407",
"triggerID" : "5245b1af2c8035c72dda41c271d8e5a251161210",
"triggerType" : "PUSH"
}, {
"hash" : "913aaebdeacc913d6b9f8498d55547aa8d480f10",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4525",
"triggerID" : "913aaebdeacc913d6b9f8498d55547aa8d480f10",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5245b1af2c8035c72dda41c271d8e5a251161210 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4407)
* 913aaebdeacc913d6b9f8498d55547aa8d480f10 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4525)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12872: [FLINK-18550][sql-client] use TableResult#collect to get select result for sql client
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12872:
URL: https://github.com/apache/flink/pull/12872#issuecomment-656681765
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5245b1af2c8035c72dda41c271d8e5a251161210",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5245b1af2c8035c72dda41c271d8e5a251161210",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5245b1af2c8035c72dda41c271d8e5a251161210 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12872: [FLINK-18550][sql-client] use TableResult#collect to get select result for sql client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12872:
URL: https://github.com/apache/flink/pull/12872#issuecomment-656681765
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5245b1af2c8035c72dda41c271d8e5a251161210",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4407",
"triggerID" : "5245b1af2c8035c72dda41c271d8e5a251161210",
"triggerType" : "PUSH"
}, {
"hash" : "913aaebdeacc913d6b9f8498d55547aa8d480f10",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "913aaebdeacc913d6b9f8498d55547aa8d480f10",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5245b1af2c8035c72dda41c271d8e5a251161210 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4407)
* 913aaebdeacc913d6b9f8498d55547aa8d480f10 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #12872: [FLINK-18550][sql-client] use TableResult#collect to get select result for sql client
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #12872:
URL: https://github.com/apache/flink/pull/12872#issuecomment-658598272
cc @twalthr It's very appreciate that you could help reviewing this pr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org