You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Knut Anders Hatlen (JIRA)" <ji...@apache.org> on 2011/08/30 15:17:38 UTC
[jira] [Created] (DERBY-5396) DRDAStatement and DRDAConnThread
swallow IOExceptions
DRDAStatement and DRDAConnThread swallow IOExceptions
-----------------------------------------------------
Key: DERBY-5396
URL: https://issues.apache.org/jira/browse/DERBY-5396
Project: Derby
Issue Type: Bug
Components: Network Server
Affects Versions: 10.8.1.2
Reporter: Knut Anders Hatlen
Assignee: Knut Anders Hatlen
DRDAConnThread.closeStream():
} catch (IOException e) {
Util.javaException(e);
}
DRDAStatement.execute():
} catch (IOException e) {
Util.javaException(e);
}
Since Util.javaException() only returns an exception, this code doesn't work as intended. The returned exception should also be thrown.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DERBY-5396) DRDAStatement and DRDAConnThread
swallow IOExceptions
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren resolved DERBY-5396.
---------------------------------------
Resolution: Fixed
Fix Version/s: 10.8.1.6
backported (with some minor manual editing of DRDAConnThread) with revision 1164755.
> DRDAStatement and DRDAConnThread swallow IOExceptions
> -----------------------------------------------------
>
> Key: DERBY-5396
> URL: https://issues.apache.org/jira/browse/DERBY-5396
> Project: Derby
> Issue Type: Bug
> Components: Network Server
> Affects Versions: 10.8.1.2
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Fix For: 10.8.1.6, 10.9.0.0
>
> Attachments: d5396.diff
>
>
> DRDAConnThread.closeStream():
> } catch (IOException e) {
> Util.javaException(e);
>
> }
> DRDAStatement.execute():
> } catch (IOException e) {
> Util.javaException(e);
> }
> Since Util.javaException() only returns an exception, this code doesn't work as intended. The returned exception should also be thrown.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5396) DRDAStatement and DRDAConnThread
swallow IOExceptions
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-5396:
--------------------------------------
Attachment: d5396.diff
The attached patch makes the suggested changes. Running regression tests now.
> DRDAStatement and DRDAConnThread swallow IOExceptions
> -----------------------------------------------------
>
> Key: DERBY-5396
> URL: https://issues.apache.org/jira/browse/DERBY-5396
> Project: Derby
> Issue Type: Bug
> Components: Network Server
> Affects Versions: 10.8.1.2
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Attachments: d5396.diff
>
>
> DRDAConnThread.closeStream():
> } catch (IOException e) {
> Util.javaException(e);
>
> }
> DRDAStatement.execute():
> } catch (IOException e) {
> Util.javaException(e);
> }
> Since Util.javaException() only returns an exception, this code doesn't work as intended. The returned exception should also be thrown.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5396) DRDAStatement and DRDAConnThread
swallow IOExceptions
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093855#comment-13093855 ]
Kathey Marsden commented on DERBY-5396:
---------------------------------------
There is issue DERBY-4350 which I am guessing can be closed as a duplicate of this, except that that issue also mentions the lack of logging, which is not addressed with the patch, but that would still be covered by DERBY-1191.
> DRDAStatement and DRDAConnThread swallow IOExceptions
> -----------------------------------------------------
>
> Key: DERBY-5396
> URL: https://issues.apache.org/jira/browse/DERBY-5396
> Project: Derby
> Issue Type: Bug
> Components: Network Server
> Affects Versions: 10.8.1.2
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Attachments: d5396.diff
>
>
> DRDAConnThread.closeStream():
> } catch (IOException e) {
> Util.javaException(e);
>
> }
> DRDAStatement.execute():
> } catch (IOException e) {
> Util.javaException(e);
> }
> Since Util.javaException() only returns an exception, this code doesn't work as intended. The returned exception should also be thrown.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DERBY-5396) DRDAStatement and DRDAConnThread
swallow IOExceptions
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen resolved DERBY-5396.
---------------------------------------
Resolution: Fixed
Fix Version/s: 10.9.0.0
Thanks, Kathey, the DRDAConnThread part of this issue is the same as DERBY-4350. I'll resolve that issue.
All the regression tests passed. Committed revision 1163616.
> DRDAStatement and DRDAConnThread swallow IOExceptions
> -----------------------------------------------------
>
> Key: DERBY-5396
> URL: https://issues.apache.org/jira/browse/DERBY-5396
> Project: Derby
> Issue Type: Bug
> Components: Network Server
> Affects Versions: 10.8.1.2
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Fix For: 10.9.0.0
>
> Attachments: d5396.diff
>
>
> DRDAConnThread.closeStream():
> } catch (IOException e) {
> Util.javaException(e);
>
> }
> DRDAStatement.execute():
> } catch (IOException e) {
> Util.javaException(e);
> }
> Since Util.javaException() only returns an exception, this code doesn't work as intended. The returned exception should also be thrown.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (DERBY-5396) DRDAStatement and DRDAConnThread
swallow IOExceptions
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren reopened DERBY-5396:
---------------------------------------
reopen for backport.
> DRDAStatement and DRDAConnThread swallow IOExceptions
> -----------------------------------------------------
>
> Key: DERBY-5396
> URL: https://issues.apache.org/jira/browse/DERBY-5396
> Project: Derby
> Issue Type: Bug
> Components: Network Server
> Affects Versions: 10.8.1.2
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Fix For: 10.9.0.0
>
> Attachments: d5396.diff
>
>
> DRDAConnThread.closeStream():
> } catch (IOException e) {
> Util.javaException(e);
>
> }
> DRDAStatement.execute():
> } catch (IOException e) {
> Util.javaException(e);
> }
> Since Util.javaException() only returns an exception, this code doesn't work as intended. The returned exception should also be thrown.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira