You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2024/10/17 11:54:20 UTC

[PR] Fix assertion [maven-dependency-plugin]

elharo opened a new pull request, #447:
URL: https://github.com/apache/maven-dependency-plugin/pull/447

   This test could never fail
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MDEP-960] Repair silent logging [maven-dependency-plugin]

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo merged PR #447:
URL: https://github.com/apache/maven-dependency-plugin/pull/447


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MDEP-960] Repair silent logging [maven-dependency-plugin]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #447:
URL: https://github.com/apache/maven-dependency-plugin/pull/447#issuecomment-2429458961

   > Yes, I'm not sure why this was done like this in the first place. This has been around since 2.0 so who knows? I am confident the way it was done is buggy, so this tries to repair as much of it as I easily could. I noticed because the tests mixed up two different silent log classes. Someone wasn't following test first practices when they wrote this.
   > 
   > If we're comfortable with some incompatibility, then we could mke the silent parameter and associated methods noops.
   
   Maybe we should deprecate for removal in 4?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MDEP-960] Repair silent logging [maven-dependency-plugin]

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #447:
URL: https://github.com/apache/maven-dependency-plugin/pull/447#issuecomment-2463124406

   Ping


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MDEP-960] Repair silent logging [maven-dependency-plugin]

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #447:
URL: https://github.com/apache/maven-dependency-plugin/pull/447#issuecomment-2429159956

   Yes, I'm not sure why this was done like this in the first place. This has been around since 2.0 so who knows? I am confident the way it was done is buggy, so this tries to repair as much of it as I easily could. I noticed because the tests mixed up two different silent log classes. Someone wasn't following test first practices when they wrote this.
   
   If we're comfortable with some incompatibility, then we could mke the silent parameter and associated methods noops.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MDEP-960] Repair silent logging [maven-dependency-plugin]

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #447:
URL: https://github.com/apache/maven-dependency-plugin/pull/447#discussion_r1835364703


##########
src/main/java/org/apache/maven/plugins/dependency/AbstractDependencyMojo.java:
##########
@@ -86,8 +87,10 @@ public abstract class AbstractDependencyMojo extends AbstractMojo {
     /**
      * If the plugin should be silent.
      *
+     * @deprecated to be removed in 4.0; use -Q command line option instead

Review Comment:
   done



##########
src/main/java/org/apache/maven/plugins/dependency/AbstractDependencyMojo.java:
##########
@@ -170,18 +173,24 @@ public void setSkip(boolean skip) {
 
     /**
      * @return {@link #silent}
+     * @deprecated to be removed in 4.0
      */
+    @Deprecated
     protected final boolean isSilent() {
         return silent;
     }
 
     /**
      * @param silent {@link #silent}
+     * @deprecated to be removed in 4.0; no API replacement, use -Q command line option instead

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MDEP-960] Repair silent logging [maven-dependency-plugin]

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #447:
URL: https://github.com/apache/maven-dependency-plugin/pull/447#issuecomment-2430104336

   OK, deprecated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MDEP-960] Repair silent logging [maven-dependency-plugin]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #447:
URL: https://github.com/apache/maven-dependency-plugin/pull/447#discussion_r1835357699


##########
src/main/java/org/apache/maven/plugins/dependency/AbstractDependencyMojo.java:
##########
@@ -86,8 +87,10 @@ public abstract class AbstractDependencyMojo extends AbstractMojo {
     /**
      * If the plugin should be silent.
      *
+     * @deprecated to be removed in 4.0; use -Q command line option instead

Review Comment:
   `-q`, not `-Q`



##########
src/main/java/org/apache/maven/plugins/dependency/AbstractDependencyMojo.java:
##########
@@ -170,18 +173,24 @@ public void setSkip(boolean skip) {
 
     /**
      * @return {@link #silent}
+     * @deprecated to be removed in 4.0
      */
+    @Deprecated
     protected final boolean isSilent() {
         return silent;
     }
 
     /**
      * @param silent {@link #silent}
+     * @deprecated to be removed in 4.0; no API replacement, use -Q command line option instead

Review Comment:
   same here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org