[GitHub] [beam] pabloem commented on a change in pull request #16072: [BEAM-13135][Playground] Add function to find all tagged files

[GitBox <gi...@apache.org>]

pabloem commented on a change in pull request #16072:
URL: https://github.com/apache/beam/pull/16072#discussion_r758431459



##########
File path: playground/categories.yaml
##########
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+categories:
+  - Side Input
+  - Side Output

Review comment:
       ```suggestion
     - Multiple Outputs
   ```

##########
File path: playground/infrastructure/helper.py
##########
@@ -44,29 +54,221 @@ def find_examples(work_dir: str) -> List[Example]:
         categories:
             - category-1
             - category-2
+    If some example contain beam tag with incorrect format raise an error.
 
     Args:
         work_dir: directory where to search examples.
+        supported_categories: list of supported categories.
 
     Returns:
         List of Examples.
     """
-    # TODO [BEAM-13135] Implement
-    pass
+    has_error = False
+    examples = []
+    for root, _, files in os.walk(work_dir):

Review comment:
       have you ran this? do you know how long it takes to run? just curious

##########
File path: playground/categories.yaml
##########
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+categories:
+  - Side Input
+  - Side Output
+  - Testing
+  - Schemas
+  - Transform

Review comment:
       maybe add
   - Batch
   - Streaming
   - Combiners
   - Dataframes
   - Joins
   
   What do you mean by 'transform' here? Maybe we can rneame it to be more clear?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org