You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/16 12:09:54 UTC

[GitHub] [incubator-tvm] vexilligera opened a new issue #4726: Export builtin_fp16 functions on Windows

vexilligera opened a new issue #4726: Export builtin_fp16 functions on Windows
URL: https://github.com/apache/incubator-tvm/issues/4726
 
 
   Hello, MXNet is working on tests involving TVMOps on Windows. When generating libtvmop.dll on Windows, the symbols of two functions required by tvmop.dll are missing. Can we export these two functions on Windows as well? The following code (src/runtime/builtin_fp16.cc) seems to work well for me.
   
   `
   #include <builtin_fp16.h>
   #include <tvm/runtime/c_runtime_api.h>
   
   extern "C" {
   
   // disable under msvc
   #ifndef _MSC_VER
   
   TVM_DLL TVM_WEAK uint16_t __gnu_f2h_ieee(float a) {
     return __truncXfYf2__<float, uint32_t, 23, uint16_t, uint16_t, 10>(a);
   }
   
   TVM_DLL TVM_WEAK float __gnu_h2f_ieee(uint16_t a) {
     return __extendXfYf2__<uint16_t, uint16_t, 10, float, uint32_t, 23>(a);
   }
   
   #else
   
   TVM_DLL uint16_t __gnu_f2h_ieee(float a) {
     return __truncXfYf2__<float, uint32_t, 23, uint16_t, uint16_t, 10>(a);
   }
   
   TVM_DLL float __gnu_h2f_ieee(uint16_t a) {
     return __extendXfYf2__<uint16_t, uint16_t, 10, float, uint32_t, 23>(a);
   }
   
   #endif
   }
   `

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] vexilligera commented on issue #4726: Export builtin_fp16 functions on Windows

Posted by GitBox <gi...@apache.org>.
vexilligera commented on issue #4726: Export builtin_fp16 functions on Windows
URL: https://github.com/apache/incubator-tvm/issues/4726#issuecomment-575495961
 
 
   > Looks good, please feel free to send a PR
   Hi, I have created a PR.
   https://github.com/apache/incubator-tvm/pull/4731

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen closed issue #4726: Export builtin_fp16 functions on Windows

Posted by GitBox <gi...@apache.org>.
tqchen closed issue #4726: Export builtin_fp16 functions on Windows
URL: https://github.com/apache/incubator-tvm/issues/4726
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen commented on issue #4726: Export builtin_fp16 functions on Windows

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4726: Export builtin_fp16 functions on Windows
URL: https://github.com/apache/incubator-tvm/issues/4726#issuecomment-575249304
 
 
   Looks good, please feel free to send a PR

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] vexilligera edited a comment on issue #4726: Export builtin_fp16 functions on Windows

Posted by GitBox <gi...@apache.org>.
vexilligera edited a comment on issue #4726: Export builtin_fp16 functions on Windows
URL: https://github.com/apache/incubator-tvm/issues/4726#issuecomment-575495961
 
 
   > Looks good, please feel free to send a PR
   
   Hi, I have created a PR. See
   https://github.com/apache/incubator-tvm/pull/4731

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services