[GitHub] [lucene-solr-operator] thelabdude commented on a change in pull request #189: Override Prometheus exporter config XML via a user-supplied ConfigMap

[GitBox <gi...@apache.org>]

thelabdude commented on a change in pull request #189:
URL: https://github.com/apache/lucene-solr-operator/pull/189#discussion_r560505507



##########
File path: controllers/solrprometheusexporter_controller.go
##########
@@ -92,10 +124,18 @@ func (r *SolrPrometheusExporterReconciler) Reconcile(req ctrl.Request) (ctrl.Res
 		if err != nil && errors.IsNotFound(err) {
 			configMapLogger.Info("Creating ConfigMap")
 			err = r.Create(context.TODO(), configMap)
+
+			// capture the MD5 for the config XML
+			configXml, _ := configMap.Data[configMapKey]
+			configXmlMd5 = fmt.Sprintf("%x", md5.Sum([]byte(configXml)))

Review comment:
       ah yes ... great catch, and thanks for fixing for solr.xml




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org