You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/01 14:23:33 UTC

[GitHub] [spark] srowen commented on a change in pull request #24264: [SPARK-27216][CORE] Upgrade RoaringBitmap to 0.7.45

srowen commented on a change in pull request #24264: [SPARK-27216][CORE] Upgrade RoaringBitmap to 0.7.45
URL: https://github.com/apache/spark/pull/24264#discussion_r270891887
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/serializer/UnsafeKryoSerializerSuite.scala
 ##########
 @@ -32,4 +34,19 @@ class UnsafeKryoSerializerSuite extends KryoSerializerSuite {
     conf.set(KRYO_USE_UNSAFE, false)
     super.afterAll()
   }
+
+  test("SPARK-27216: Upgrade RoaringBitmap to 0.7.45 to fix Kryo unsafe ser/dser issue") {
+    val expected = new RoaringBitmap
 
 Review comment:
   Tiny nit: () after the constructor

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org