You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/10 11:00:49 UTC
[GitHub] [dolphinscheduler] kezhenxu94 commented on a change in pull request #8815: [Feature][E2E] Restore security center e2e test cases in ui-next
kezhenxu94 commented on a change in pull request #8815:
URL: https://github.com/apache/dolphinscheduler/pull/8815#discussion_r823597876
##########
File path: dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/QueueE2ETest.java
##########
@@ -86,7 +86,8 @@ void testCreateDuplicateQueue() {
@Test
@Order(30)
void testEditQueue() {
- final QueuePage page = new QueuePage(browser);
+ QueuePage page = new QueuePage(browser);
Review comment:
Should be reverted?
```suggestion
final QueuePage page = new QueuePage(browser);
```
##########
File path: dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/FunctionManageE2ETest.java
##########
@@ -83,28 +83,28 @@
@BeforeAll
@SneakyThrows
public static void setup() {
- TenantPage tenantPage = new LoginPage(browser)
- .login(user, password)
- .create(tenant);
-
- await().untilAsserted(() -> assertThat(tenantPage.tenantList())
- .as("Tenant list should contain newly-created tenant")
- .extracting(WebElement::getText)
- .anyMatch(it -> it.contains(tenant)));
-
- downloadFile("https://repo1.maven.org/maven2/org/apache/hive/hive-jdbc/3.1.2/hive-jdbc-3.1.2.jar", testUploadUdfFilePath.toFile().getAbsolutePath());
-
- UdfManagePage udfManagePage = tenantPage.goToNav(SecurityPage.class)
- .goToTab(UserPage.class)
- .update(user, user, password, email, phone)
- .goToNav(ResourcePage.class)
- .goToTab(UdfManagePage.class)
- .uploadFile(testUploadUdfFilePath.toFile().getAbsolutePath());
-
- new WebDriverWait(browser, 10).until(ExpectedConditions.invisibilityOfElementLocated(By.id("fileUpdateDialog")));
-
- udfManagePage.goToNav(ResourcePage.class)
- .goToTab(FunctionManagePage.class);
+// TenantPage tenantPage = new LoginPage(browser)
+// .login(user, password)
+// .create(tenant);
+//
+// await().untilAsserted(() -> assertThat(tenantPage.tenantList())
+// .as("Tenant list should contain newly-created tenant")
+// .extracting(WebElement::getText)
+// .anyMatch(it -> it.contains(tenant)));
+//
+// downloadFile("https://repo1.maven.org/maven2/org/apache/hive/hive-jdbc/3.1.2/hive-jdbc-3.1.2.jar", testUploadUdfFilePath.toFile().getAbsolutePath());
+//
+// UdfManagePage udfManagePage = tenantPage.goToNav(SecurityPage.class)
+// .goToTab(UserPage.class)
+// .update(user, user, password, email, phone)
+// .goToNav(ResourcePage.class)
+// .goToTab(UdfManagePage.class)
+// .uploadFile(testUploadUdfFilePath.toFile().getAbsolutePath());
+//
+// new WebDriverWait(browser, 10).until(ExpectedConditions.invisibilityOfElementLocated(By.id("fileUpdateDialog")));
+//
+// udfManagePage.goToNav(ResourcePage.class)
+// .goToTab(FunctionManagePage.class);
Review comment:
Should be reverted?
##########
File path: dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/FileManageE2ETest.java
##########
@@ -84,20 +84,20 @@
@BeforeAll
public static void setup() {
- TenantPage tenantPage = new LoginPage(browser)
- .login(user, password)
- .create(tenant);
-
- await().untilAsserted(() -> assertThat(tenantPage.tenantList())
- .as("Tenant list should contain newly-created tenant")
- .extracting(WebElement::getText)
- .anyMatch(it -> it.contains(tenant)));
-
- tenantPage.goToNav(SecurityPage.class)
- .goToTab(UserPage.class)
- .update(user, user, password, email, phone)
- .goToNav(ResourcePage.class)
- .goToTab(FileManagePage.class);
+// TenantPage tenantPage = new LoginPage(browser)
+// .login(user, password)
+// .create(tenant);
+//
+// await().untilAsserted(() -> assertThat(tenantPage.tenantList())
+// .as("Tenant list should contain newly-created tenant")
+// .extracting(WebElement::getText)
+// .anyMatch(it -> it.contains(tenant)));
+//
+// tenantPage.goToNav(SecurityPage.class)
+// .goToTab(UserPage.class)
+// .update(user, user, password, email, phone)
+// .goToNav(ResourcePage.class)
+// .goToTab(FileManagePage.class);
Review comment:
These should be reverted?
##########
File path: dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/UserE2ETest.java
##########
@@ -126,21 +127,21 @@ void testEditUser() {
}
- @Test
- @Order(40)
- void testDeleteUser() {
- final UserPage page = new UserPage(browser);
-
- page.delete(editUser);
-
- await().untilAsserted(() -> {
- browser.navigate().refresh();
-
- assertThat(
- page.userList()
- ).noneMatch(
- it -> it.getText().contains(user) || it.getText().contains(editUser)
- );
- });
- }
+// @Test
+// @Order(40)
+// void testDeleteUser() {
+// final UserPage page = new UserPage(browser);
+//
+// page.delete(editUser);
+//
+// await().untilAsserted(() -> {
+// browser.navigate().refresh();
+//
+// assertThat(
+// page.userList()
+// ).noneMatch(
+// it -> it.getText().contains(user) || it.getText().contains(editUser)
+// );
+// });
+// }
Review comment:
Can we uncomment these lines?
##########
File path: dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/TokenE2ETest.java
##########
@@ -52,8 +52,8 @@ public static void setup() {
@Test
@Order(10)
void testCreateToken() {
- final TokenPage page = new TokenPage(browser);
- page.create();
+ TokenPage page = new TokenPage(browser);
Review comment:
Why remove these `final`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org