You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/27 03:53:40 UTC

[GitHub] [spark] zhengruifeng commented on a diff in pull request #39229: [SPARK-41473][CONNECT][PYTHON] Implement `format_number` function

zhengruifeng commented on code in PR #39229:
URL: https://github.com/apache/spark/pull/39229#discussion_r1057425058


##########
python/pyspark/sql/connect/functions.py:
##########
@@ -1629,11 +1629,11 @@ def encode(col: "ColumnOrName", charset: str) -> Column:
 encode.__doc__ = pysparkfuncs.encode.__doc__
 
 
-# TODO(SPARK-41473): Resolve the data type mismatch issue and enable the function

Review Comment:
   the issue of datatype mismatch had been resolved



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org