You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by "cdmikechen (via GitHub)" <gi...@apache.org> on 2023/06/10 12:02:02 UTC
[GitHub] [submarine] cdmikechen opened a new pull request, #1069: SUBMARINE-1383. Update submarine-sdk generated client api
cdmikechen opened a new pull request, #1069:
URL: https://github.com/apache/submarine/pull/1069
### What is this PR for?
With the upgrade, we have fixed fixed an issue in server openapi endpoint caused by missing dependency in the meantime.
At the same time, in order to ensure the validity of the openapi-generator-cli generated codes, we continue to use the old code generation method for the time being.
### What type of PR is it?
Bug Fix
### Todos
* [x] - Update sdk api by `gen-sdk.sh` (keep openapi-generator-cli method with keeping python2 and python3).
* [x] - Fix submarine server openapi endpoint error.
* [x] - Add a test case for openapi endpoint.
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1383
### How should this be tested?
Git CI
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] codecov[bot] commented on pull request #1069: SUBMARINE-1383. Update submarine-sdk generated client api
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1069:
URL: https://github.com/apache/submarine/pull/1069#issuecomment-1585637919
## [Codecov](https://app.codecov.io/gh/apache/submarine/pull/1069?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1069](https://app.codecov.io/gh/apache/submarine/pull/1069?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e7a4ed4) into [master](https://app.codecov.io/gh/apache/submarine/commit/b830ac4adbfa0a1edf3810efcfe062cbce1b1892?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b830ac4) will **decrease** coverage by `30.76%`.
> The diff coverage is `21.64%`.
> :exclamation: Current head e7a4ed4 differs from pull request most recent head 4f5e672. Consider uploading reports for the commit 4f5e672 to get more accurate results
```diff
@@ Coverage Diff @@
## master #1069 +/- ##
===========================================
- Coverage 75.98% 45.22% -30.76%
===========================================
Files 119 127 +8
Lines 5000 5806 +806
===========================================
- Hits 3799 2626 -1173
- Misses 1201 3180 +1979
```
| Flag | Coverage Δ | |
|---|---|---|
| python-integration | `?` | |
| python-unit | `45.22% <21.64%> (-7.26%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/submarine/pull/1069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pysubmarine/submarine/client/api/experiment\_api.py](https://app.codecov.io/gh/apache/submarine/pull/1069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvY2xpZW50L2FwaS9leHBlcmltZW50X2FwaS5weQ==) | `10.89% <5.67%> (-40.83%)` | :arrow_down: |
| [...ine-sdk/pysubmarine/submarine/client/exceptions.py](https://app.codecov.io/gh/apache/submarine/pull/1069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvY2xpZW50L2V4Y2VwdGlvbnMucHk=) | `25.49% <7.69%> (-8.51%)` | :arrow_down: |
| [...ysubmarine/submarine/client/api/environment\_api.py](https://app.codecov.io/gh/apache/submarine/pull/1069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvY2xpZW50L2FwaS9lbnZpcm9ubWVudF9hcGkucHk=) | `14.18% <9.25%> (-60.46%)` | :arrow_down: |
| [...ubmarine/submarine/client/api/model\_version\_api.py](https://app.codecov.io/gh/apache/submarine/pull/1069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvY2xpZW50L2FwaS9tb2RlbF92ZXJzaW9uX2FwaS5weQ==) | `10.61% <10.61%> (ø)` | |
| [...arine/submarine/client/api/registered\_model\_api.py](https://app.codecov.io/gh/apache/submarine/pull/1069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvY2xpZW50L2FwaS9yZWdpc3RlcmVkX21vZGVsX2FwaS5weQ==) | `11.32% <11.32%> (ø)` | |
| [...k/pysubmarine/submarine/client/api/notebook\_api.py](https://app.codecov.io/gh/apache/submarine/pull/1069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvY2xpZW50L2FwaS9ub3RlYm9va19hcGkucHk=) | `14.92% <13.72%> (-64.47%)` | :arrow_down: |
| [...ine-sdk/pysubmarine/submarine/client/api\_client.py](https://app.codecov.io/gh/apache/submarine/pull/1069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvY2xpZW50L2FwaV9jbGllbnQucHk=) | `19.85% <14.28%> (-42.69%)` | :arrow_down: |
| [...e/submarine/client/api/experiment\_templates\_api.py](https://app.codecov.io/gh/apache/submarine/pull/1069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvY2xpZW50L2FwaS9leHBlcmltZW50X3RlbXBsYXRlc19hcGkucHk=) | `15.55% <15.55%> (ø)` | |
| [...ne/submarine/client/api/experiment\_template\_api.py](https://app.codecov.io/gh/apache/submarine/pull/1069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvY2xpZW50L2FwaS9leHBlcmltZW50X3RlbXBsYXRlX2FwaS5weQ==) | `19.35% <19.35%> (ø)` | |
| [...-sdk/pysubmarine/submarine/client/api/serve\_api.py](https://app.codecov.io/gh/apache/submarine/pull/1069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvY2xpZW50L2FwaS9zZXJ2ZV9hcGkucHk=) | `19.51% <21.21%> (+3.05%)` | :arrow_up: |
| ... and [21 more](https://app.codecov.io/gh/apache/submarine/pull/1069?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [31 files with indirect coverage changes](https://app.codecov.io/gh/apache/submarine/pull/1069/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #1069: SUBMARINE-1383. Update submarine-sdk generated client api
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #1069: SUBMARINE-1383. Update submarine-sdk generated client api
URL: https://github.com/apache/submarine/pull/1069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org