[GitHub] [superset] kgabryje commented on pull request #20498: [WIP] chore(explore): Update chart save to use API endpoints

[GitBox <gi...@apache.org>]

kgabryje commented on PR #20498:
URL: https://github.com/apache/superset/pull/20498#issuecomment-1174999023

   Can we get rid of page refresh when you overwrite the chart? I removed `window.location.assign(`/explore/?slice_id=${value.id}`);` from `SaveModal.tsx` and it seems to be working. The only problem is that "altered" pill doesn't disappear but I think that can be fixed easily by updating `explore.slice` (since slice holds the metadata of saved chart)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org