You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Elliott Clark (Created) (JIRA)" <ji...@apache.org> on 2012/04/17 03:08:17 UTC
[jira] [Created] (HBASE-5802) Change the default metrics class to
NullContextWithUpdateThread
Change the default metrics class to NullContextWithUpdateThread
---------------------------------------------------------------
Key: HBASE-5802
URL: https://issues.apache.org/jira/browse/HBASE-5802
Project: HBase
Issue Type: Improvement
Reporter: Elliott Clark
Assignee: Elliott Clark
Priority: Minor
Since lots more metrics are being placed into the Dynamic metrics bucket changing the default class to NullContextWithUpdateThread seems like it might be worth it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5802) Change the default metrics class to
NullContextWithUpdateThread
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255295#comment-13255295 ]
stack commented on HBASE-5802:
------------------------------
So, enable jmx emissions? Would suggest that your patch include comment explaining what the exotic-sounding NullContextWithUpdateThread does. Maybe copy the class comment into your patch somewhere:
{code}
* A null context which has a thread calling
* periodically when monitoring is started. This keeps the data sampled
* correctly.
* In all other respects, this is like the NULL context: No data is emitted.
* This is suitable for Monitoring systems like JMX which reads the metrics
* when someone reads the data from JMX.
*
* The default impl of start and stop monitoring:
* is the AbstractMetricsContext is good enough.
{code}
Maybe update the reference guide too especially if you are changing default.
Good stuff E.
> Change the default metrics class to NullContextWithUpdateThread
> ---------------------------------------------------------------
>
> Key: HBASE-5802
> URL: https://issues.apache.org/jira/browse/HBASE-5802
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Minor
> Attachments: HBASE-5802-0.patch
>
>
> Since lots more metrics are being placed into the Dynamic metrics bucket changing the default class to NullContextWithUpdateThread seems like it might be worth it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5802) Change the default metrics class to
NullContextWithUpdateThread
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278254#comment-13278254 ]
Hudson commented on HBASE-5802:
-------------------------------
Integrated in HBase-0.94 #195 (See [https://builds.apache.org/job/HBase-0.94/195/])
HBASE-5802 Change the default metrics class to NullContextWithUpdateThread (Revision 1339832)
Result = SUCCESS
stack :
Files :
* /hbase/branches/0.94/conf/hadoop-metrics.properties
* /hbase/branches/0.94/src/site/xdoc/metrics.xml
> Change the default metrics class to NullContextWithUpdateThread
> ---------------------------------------------------------------
>
> Key: HBASE-5802
> URL: https://issues.apache.org/jira/browse/HBASE-5802
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Minor
> Fix For: 0.94.1
>
> Attachments: HBASE-5802-0.patch, HBASE-5802-1.patch, HBASE-5802-2.patch
>
>
> Since lots more metrics are being placed into the Dynamic metrics bucket changing the default class to NullContextWithUpdateThread seems like it might be worth it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5802) Change the default metrics class to
NullContextWithUpdateThread
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278429#comment-13278429 ]
Hudson commented on HBASE-5802:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #8 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/8/])
HBASE-5802 Change the default metrics class to NullContextWithUpdateThread (Revision 1339831)
Result = FAILURE
stack :
Files :
* /hbase/trunk/conf/hadoop-metrics.properties
* /hbase/trunk/src/site/xdoc/metrics.xml
> Change the default metrics class to NullContextWithUpdateThread
> ---------------------------------------------------------------
>
> Key: HBASE-5802
> URL: https://issues.apache.org/jira/browse/HBASE-5802
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Minor
> Fix For: 0.94.1
>
> Attachments: HBASE-5802-0.patch, HBASE-5802-1.patch, HBASE-5802-2.patch
>
>
> Since lots more metrics are being placed into the Dynamic metrics bucket changing the default class to NullContextWithUpdateThread seems like it might be worth it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5802) Change the default metrics class to
NullContextWithUpdateThread
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-5802:
---------------------------------
Attachment: HBASE-5802-2.patch
> Change the default metrics class to NullContextWithUpdateThread
> ---------------------------------------------------------------
>
> Key: HBASE-5802
> URL: https://issues.apache.org/jira/browse/HBASE-5802
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Minor
> Attachments: HBASE-5802-0.patch, HBASE-5802-1.patch, HBASE-5802-2.patch
>
>
> Since lots more metrics are being placed into the Dynamic metrics bucket changing the default class to NullContextWithUpdateThread seems like it might be worth it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5802) Change the default metrics class to
NullContextWithUpdateThread
Posted by "Elliott Clark (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-5802:
---------------------------------
Attachment: HBASE-5802-0.patch
Trivial patch just to get discussion started.
> Change the default metrics class to NullContextWithUpdateThread
> ---------------------------------------------------------------
>
> Key: HBASE-5802
> URL: https://issues.apache.org/jira/browse/HBASE-5802
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Minor
> Attachments: HBASE-5802-0.patch
>
>
> Since lots more metrics are being placed into the Dynamic metrics bucket changing the default class to NullContextWithUpdateThread seems like it might be worth it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-5802) Change the default metrics class to
NullContextWithUpdateThread
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-5802.
--------------------------
Resolution: Fixed
Fix Version/s: 0.94.1
Hadoop Flags: Incompatible change,Reviewed
I marked it as incompatible change though innocuous. Thanks for the patch Elliott. Applied to 0.94 branch and to trunk.
> Change the default metrics class to NullContextWithUpdateThread
> ---------------------------------------------------------------
>
> Key: HBASE-5802
> URL: https://issues.apache.org/jira/browse/HBASE-5802
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Minor
> Fix For: 0.94.1
>
> Attachments: HBASE-5802-0.patch, HBASE-5802-1.patch, HBASE-5802-2.patch
>
>
> Since lots more metrics are being placed into the Dynamic metrics bucket changing the default class to NullContextWithUpdateThread seems like it might be worth it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5802) Change the default metrics class to
NullContextWithUpdateThread
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279423#comment-13279423 ]
Hudson commented on HBASE-5802:
-------------------------------
Integrated in HBase-0.94-security #27 (See [https://builds.apache.org/job/HBase-0.94-security/27/])
HBASE-5802 Change the default metrics class to NullContextWithUpdateThread (Revision 1339832)
Result = SUCCESS
stack :
Files :
* /hbase/branches/0.94/conf/hadoop-metrics.properties
* /hbase/branches/0.94/src/site/xdoc/metrics.xml
> Change the default metrics class to NullContextWithUpdateThread
> ---------------------------------------------------------------
>
> Key: HBASE-5802
> URL: https://issues.apache.org/jira/browse/HBASE-5802
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Minor
> Fix For: 0.94.1
>
> Attachments: HBASE-5802-0.patch, HBASE-5802-1.patch, HBASE-5802-2.patch
>
>
> Since lots more metrics are being placed into the Dynamic metrics bucket changing the default class to NullContextWithUpdateThread seems like it might be worth it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HBASE-5802) Change the default metrics class to
NullContextWithUpdateThread
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl closed HBASE-5802.
--------------------------------
> Change the default metrics class to NullContextWithUpdateThread
> ---------------------------------------------------------------
>
> Key: HBASE-5802
> URL: https://issues.apache.org/jira/browse/HBASE-5802
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Minor
> Fix For: 0.94.1
>
> Attachments: HBASE-5802-0.patch, HBASE-5802-1.patch, HBASE-5802-2.patch
>
>
> Since lots more metrics are being placed into the Dynamic metrics bucket changing the default class to NullContextWithUpdateThread seems like it might be worth it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5802) Change the default metrics class to
NullContextWithUpdateThread
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-5802:
---------------------------------
Attachment: HBASE-5802-1.patch
Patch with some comments and a change to the site.
> Change the default metrics class to NullContextWithUpdateThread
> ---------------------------------------------------------------
>
> Key: HBASE-5802
> URL: https://issues.apache.org/jira/browse/HBASE-5802
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Minor
> Attachments: HBASE-5802-0.patch, HBASE-5802-1.patch
>
>
> Since lots more metrics are being placed into the Dynamic metrics bucket changing the default class to NullContextWithUpdateThread seems like it might be worth it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5802) Change the default metrics class to
NullContextWithUpdateThread
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278046#comment-13278046 ]
stack commented on HBASE-5802:
------------------------------
Elliott: You going to add comments? We should backport to 0.94 especially if we are going to update 0.94 to hadoop 1.0.3, etc, and make /jmx work.
> Change the default metrics class to NullContextWithUpdateThread
> ---------------------------------------------------------------
>
> Key: HBASE-5802
> URL: https://issues.apache.org/jira/browse/HBASE-5802
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Minor
> Attachments: HBASE-5802-0.patch
>
>
> Since lots more metrics are being placed into the Dynamic metrics bucket changing the default class to NullContextWithUpdateThread seems like it might be worth it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5802) Change the default metrics class to
NullContextWithUpdateThread
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278248#comment-13278248 ]
Hudson commented on HBASE-5802:
-------------------------------
Integrated in HBase-TRUNK #2893 (See [https://builds.apache.org/job/HBase-TRUNK/2893/])
HBASE-5802 Change the default metrics class to NullContextWithUpdateThread (Revision 1339831)
Result = SUCCESS
stack :
Files :
* /hbase/trunk/conf/hadoop-metrics.properties
* /hbase/trunk/src/site/xdoc/metrics.xml
> Change the default metrics class to NullContextWithUpdateThread
> ---------------------------------------------------------------
>
> Key: HBASE-5802
> URL: https://issues.apache.org/jira/browse/HBASE-5802
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Minor
> Fix For: 0.94.1
>
> Attachments: HBASE-5802-0.patch, HBASE-5802-1.patch, HBASE-5802-2.patch
>
>
> Since lots more metrics are being placed into the Dynamic metrics bucket changing the default class to NullContextWithUpdateThread seems like it might be worth it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5802) Change the default metrics class to
NullContextWithUpdateThread
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278117#comment-13278117 ]
Elliott Clark commented on HBASE-5802:
--------------------------------------
Yep working on this right now so that 0.94.1 can get this.
> Change the default metrics class to NullContextWithUpdateThread
> ---------------------------------------------------------------
>
> Key: HBASE-5802
> URL: https://issues.apache.org/jira/browse/HBASE-5802
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Minor
> Attachments: HBASE-5802-0.patch
>
>
> Since lots more metrics are being placed into the Dynamic metrics bucket changing the default class to NullContextWithUpdateThread seems like it might be worth it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira