You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/06/03 15:52:46 UTC
[GitHub] [logging-log4j2] rgoers commented on a change in pull request #502: Improvements:
rgoers commented on a change in pull request #502:
URL: https://github.com/apache/logging-log4j2/pull/502#discussion_r644304021
##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/FileExtension.java
##########
@@ -95,7 +95,7 @@ public static FileExtension lookupForFile(final String fileName) {
private final String extension;
- private FileExtension(final String extension) {
+ FileExtension(final String extension) {
Review comment:
Why is this being changed from private to package?
##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/net/Rfc1349TrafficClass.java
##########
@@ -39,7 +39,7 @@
private final int trafficClass;
- private Rfc1349TrafficClass(final int trafficClass) {
+ Rfc1349TrafficClass(final int trafficClass) {
Review comment:
Why is this being changed to package from private?
##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/time/internal/format/FixedDateFormat.java
##########
@@ -324,11 +324,11 @@ public int getSecondFractionDigits() {
*/
HHCMM(':', true, 6);
- private FixedTimeZoneFormat() {
+ FixedTimeZoneFormat() {
Review comment:
Why is this being changed to package from private?
##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/time/internal/format/FixedDateFormat.java
##########
@@ -324,11 +324,11 @@ public int getSecondFractionDigits() {
*/
HHCMM(':', true, 6);
- private FixedTimeZoneFormat() {
+ FixedTimeZoneFormat() {
this(NONE, true, 4);
}
- private FixedTimeZoneFormat(final char timeSeparatorChar, final boolean minutes, final int length) {
+ FixedTimeZoneFormat(final char timeSeparatorChar, final boolean minutes, final int length) {
Review comment:
Why is this being changed to package from private?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org