You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2023/01/06 20:18:31 UTC

[GitHub] [tinkerpop] Cole-Greer opened a new pull request, #1933: Adds additional docs for dedup step

Cole-Greer opened a new pull request, #1933:
URL: https://github.com/apache/tinkerpop/pull/1933

   Adds a section in the gremlin-semantics docs for the dedup step.
   
   Main purpose of this is to highlight some extra considerations with dedup implementation which are somewhat beyond the scope of the reference docs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] xiazcy commented on pull request #1933: Adds additional docs for dedup step

Posted by GitBox <gi...@apache.org>.
xiazcy commented on PR #1933:
URL: https://github.com/apache/tinkerpop/pull/1933#issuecomment-1379393262

   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] xiazcy merged pull request #1933: Adds additional docs for dedup step

Posted by GitBox <gi...@apache.org>.
xiazcy merged PR #1933:
URL: https://github.com/apache/tinkerpop/pull/1933


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] codecov-commenter commented on pull request #1933: Adds additional docs for dedup step

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1933:
URL: https://github.com/apache/tinkerpop/pull/1933#issuecomment-1374113064

   # [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1933?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1933](https://codecov.io/gh/apache/tinkerpop/pull/1933?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5679f0a) into [3.6-dev](https://codecov.io/gh/apache/tinkerpop/commit/891e38ff9131766671c78d6bf33a6bbcf104552f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (891e38f) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             3.6-dev    #1933      +/-   ##
   =============================================
   - Coverage      69.32%   69.32%   -0.01%     
   + Complexity      9363     9361       -2     
   =============================================
     Files            879      879              
     Lines          41980    41990      +10     
     Branches        5652     5656       +4     
   =============================================
   + Hits           29104    29108       +4     
   + Misses         10885    10883       -2     
   - Partials        1991     1999       +8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/1933?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../gremlin/driver/exception/ConnectionException.java](https://codecov.io/gh/apache/tinkerpop/pull/1933?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9leGNlcHRpb24vQ29ubmVjdGlvbkV4Y2VwdGlvbi5qYXZh) | `22.22% <0.00%> (-22.23%)` | :arrow_down: |
   | [...sal/strategy/optimization/GraphFilterStrategy.java](https://codecov.io/gh/apache/tinkerpop/pull/1933?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL2NvbXB1dGVyL3RyYXZlcnNhbC9zdHJhdGVneS9vcHRpbWl6YXRpb24vR3JhcGhGaWx0ZXJTdHJhdGVneS5qYXZh) | `64.06% <0.00%> (-4.69%)` | :arrow_down: |
   | [...java/org/apache/tinkerpop/gremlin/driver/Host.java](https://codecov.io/gh/apache/tinkerpop/pull/1933?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9Ib3N0LmphdmE=) | `35.55% <0.00%> (-2.23%)` | :arrow_down: |
   | [...tinkerpop/gremlin/jsr223/GremlinScriptChecker.java](https://codecov.io/gh/apache/tinkerpop/pull/1933?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9qc3IyMjMvR3JlbWxpblNjcmlwdENoZWNrZXIuamF2YQ==) | `92.85% <0.00%> (-1.59%)` | :arrow_down: |
   | [gremlin-go/driver/anonymousTraversal.go](https://codecov.io/gh/apache/tinkerpop/pull/1933?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvYW5vbnltb3VzVHJhdmVyc2FsLmdv) | `45.77% <0.00%> (-0.89%)` | :arrow_down: |
   | [...pache/tinkerpop/gremlin/driver/ConnectionPool.java](https://codecov.io/gh/apache/tinkerpop/pull/1933?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9Db25uZWN0aW9uUG9vbC5qYXZh) | `28.89% <0.00%> (-0.65%)` | :arrow_down: |
   | [...apache/tinkerpop/gremlin/server/GremlinServer.java](https://codecov.io/gh/apache/tinkerpop/pull/1933?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci9HcmVtbGluU2VydmVyLmphdmE=) | `56.58% <0.00%> (-0.49%)` | :arrow_down: |
   | [...nkerpop/gremlin/groovy/engine/GremlinExecutor.java](https://codecov.io/gh/apache/tinkerpop/pull/1933?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1ncm9vdnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2dyb292eS9lbmdpbmUvR3JlbWxpbkV4ZWN1dG9yLmphdmE=) | `87.24% <0.00%> (-0.42%)` | :arrow_down: |
   | [...in/process/traversal/dsl/graph/GraphTraversal.java](https://codecov.io/gh/apache/tinkerpop/pull/1933?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9kc2wvZ3JhcGgvR3JhcGhUcmF2ZXJzYWwuamF2YQ==) | `90.85% <0.00%> (+0.32%)` | :arrow_up: |
   | [...mlin/server/op/traversal/TraversalOpProcessor.java](https://codecov.io/gh/apache/tinkerpop/pull/1933?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci9vcC90cmF2ZXJzYWwvVHJhdmVyc2FsT3BQcm9jZXNzb3IuamF2YQ==) | `48.38% <0.00%> (+0.92%)` | :arrow_up: |
   | ... and [2 more](https://codecov.io/gh/apache/tinkerpop/pull/1933?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] vkagamlyk commented on pull request #1933: Adds additional docs for dedup step

Posted by GitBox <gi...@apache.org>.
vkagamlyk commented on PR #1933:
URL: https://github.com/apache/tinkerpop/pull/1933#issuecomment-1377578583

   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org