[jira] [Commented] (TINKERPOP-2517) Introduce a retry status code to the server protocol

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17289890#comment-17289890 ] 

ASF GitHub Bot commented on TINKERPOP-2517:
-------------------------------------------

spmallette opened a new pull request #1398:
URL: https://github.com/apache/tinkerpop/pull/1398


   https://issues.apache.org/jira/browse/TINKERPOP-2517
   
   Implemented `TemporaryException` as an interface which means we can't really try-catch it but this approach is probably easier for providers who already have existing exception hierarchies and would just like to be able to hook into Gremlin Server's `TemporaryException` to `ResponseStatusCode.SERVER_ERROR_TEMPORARY` mapping and to not introduce breaks into embedded mode implementations where certain hierarchies are already expected.
   
   Targeted `master` rather than `3.4-dev` as I have some concerns about serialization of enums and compatibility there. Also, this feels like a new enough piece of functionality (though a simple implementation in TinkerPop) that it should come with a minor upgrade. 
   
   All tests pass with `docker/build.sh -t -n -i`
   
   VOTE +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Introduce a retry status code to the server protocol
> ----------------------------------------------------
>
>                 Key: TINKERPOP-2517
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2517
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.4.10
>            Reporter: Stephen Mallette
>            Priority: Major
>
> There is no common server code that defines when applications should retry a request. Without such a code, developers are left to (1) write provider specific code (i.e. Neptune retry codes vs JanusServer codes) and/or (2) parse response error messages to determine if retry is needed. If TinkerPop specified a code or code series that signified retry users could easily depend on it in their application logic. We would not look to implement retry logic in the drivers themselves - that would remain a task for application developers.  Looking at the current response codes I'd think that we would just add {{SERVER_ERROR_TEMPORARY 596}}
> cc/ [~divijvaidya]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)