[GitHub] spark pull request #18587: [SPARK-12559][Mesos] fix --packages for mesos

[skonto <gi...@git.apache.org>]

Github user skonto commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18587#discussion_r126382374
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -269,6 +269,25 @@ object SparkSubmit extends CommandLineUtils {
           }
         }
     
    +    // Fail fast, the following modes are not supported or applicable
    +    (clusterManager, deployMode) match {
    +      case (STANDALONE, CLUSTER) if args.isPython =>
    +        printErrorAndExit("Cluster deploy mode is currently not supported for python " +
    +          "applications on standalone clusters.")
    +      case (STANDALONE, CLUSTER) if args.isR =>
    +        printErrorAndExit("Cluster deploy mode is currently not supported for R " +
    +          "applications on standalone clusters.")
    +      case (LOCAL, CLUSTER) =>
    +        printErrorAndExit("Cluster deploy mode is not compatible with master \"local\"")
    +      case (_, CLUSTER) if isShell(args.primaryResource) =>
    +        printErrorAndExit("Cluster deploy mode is not applicable to Spark shells.")
    +      case (_, CLUSTER) if isSqlShell(args.mainClass) =>
    +        printErrorAndExit("Cluster deploy mode is not applicable to Spark SQL shell.")
    +      case (_, CLUSTER) if isThriftServer(args.mainClass) =>
    +        printErrorAndExit("Cluster deploy mode is not applicable to Spark Thrift server.")
    +      case _ =>
    +    }
    +
    --- End diff --
    
    This is for failing faster no need to resolve dependencies if we are going to fail.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org