You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "RNHTTR (via GitHub)" <gi...@apache.org> on 2024/11/02 21:27:19 UTC
Re: [PR] Implement on_killed support for tasks during DAG run timeout [airflow]
RNHTTR commented on code in PR #42005:
URL: https://github.com/apache/airflow/pull/42005#discussion_r1826845945
##########
airflow/models/baseoperator.py:
##########
@@ -909,6 +909,7 @@ def __init__(
task_display_name: str | None = None,
logger_name: str | None = None,
allow_nested_operators: bool = True,
+ call_on_kill_on_dagrun_timeout: bool = True,
Review Comment:
IMO this would be a good change. It's somewhat counterintuitive that tasks will be marked as skipped when a Dagrun times out, and enabling `on_kill` on Dagrun timeout _is_ intuitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org