You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/02/16 18:27:54 UTC

[GitHub] dstandish commented on a change in pull request #4721: [AIRFLOW-3901] add role as optional config parameter for SnowflakeHook

dstandish commented on a change in pull request #4721: [AIRFLOW-3901] add role as optional config parameter for SnowflakeHook
URL: https://github.com/apache/airflow/pull/4721#discussion_r257470609
 
 

 ##########
 File path: airflow/contrib/hooks/snowflake_hook.py
 ##########
 @@ -69,9 +72,8 @@ def get_uri(self):
         """
         conn_config = self._get_conn_params()
         uri = 'snowflake://{user}:{password}@{account}/{database}/'
-        uri += '{schema}?warehouse={warehouse}'
-        return uri.format(
-            **conn_config)
+        uri += '{schema}?warehouse={warehouse}&role={role}'
 
 Review comment:
   
   I tested the uri when role is not supplied. It does not hurt anything to have the empty role=. Though it is not obvious.  Should I add logic to only include that key in URI when val > ''?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services